This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
This sets the default timeout and retries for the IAM service #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2158
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
+ Coverage 33.36% 33.42% +0.05%
==========================================
Files 66 66
Lines 7876 7883 +7
==========================================
+ Hits 2628 2635 +7
Misses 4928 4928
Partials 320 320
|
rgulewich
reviewed
Sep 28, 2018
| @@ -68,6 +68,8 @@ func NewConfig() (*Config, []cli.Flag) { | |||
| hardCodedEnv: []string{ | |||
| "NETFLIX_APPUSER=appuser", | |||
| "EC2_DOMAIN=amazonaws.com", | |||
| "AWS_METADATA_SERVICE_TIMEOUT=5", | |||
There was a problem hiding this comment.
Maybe add a comment that these are standard AWS SDK environment vars? Other than that, LGTM.
rgulewich
approved these changes
Sep 28, 2018
sargun
force-pushed
the
set-aws-metadata-timeout
branch
from
82cee67
to
cd91414
Compare
…er numbers. When the container hits the metadata service for its IAM credentials, we lazily request them. The Boto client expects this API to return in less than one second and return credentials. This bumps the retries, and timeout to a bigger number.
sargun
force-pushed
the
set-aws-metadata-timeout
branch
from
cd91414
to
fb8675f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the container hits the metadata service for its IAM credentials, we lazily request them.
The Boto client expects this API to return in less than one second and return credentials.
This bumps the retries, and timeout to a bigger number.