Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Linting docs, test and build changes #187

Merged
merged 5 commits into from
Oct 5, 2018
Merged

Linting docs, test and build changes #187

merged 5 commits into from
Oct 5, 2018

Conversation

rgulewich
Copy link
Contributor

This includes:

  • Adding linting instructions to the README
  • Fixing a build issue when you've been doing multiple builds on the same machine
  • Allowing the docker in docker test timeout to be overridden
  • A minor Makefile comment fix

@rgulewich rgulewich requested a review from sargun October 5, 2018 16:52
@@ -117,7 +117,7 @@ if [[ $num_debs -ne 1 ]]; then
exit 1
fi

filename=${outdir}/*.deb
filename=$(ls -t ${outdir}/*.deb | grep -v latest | head -n 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1t

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, what's wrong with selecting on latest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 is the default when ls is not run in a shell. Latest is the symlink: we want to grab the source file here.

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #187 into master will increase coverage by 9.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   21.62%   31.44%   +9.81%     
==========================================
  Files          66       66              
  Lines        8393     8393              
==========================================
+ Hits         1815     2639     +824     
+ Misses       6365     5435     -930     
- Partials      213      319     +106
Impacted Files Coverage Δ
filesystems/watcher.go 62% <0%> (+3.71%) ⬆️
config/config.go 97.1% <0%> (+4.34%) ⬆️
uploader/copy.go 50% <0%> (+5%) ⬆️
api/netflix/titus/agent.pb.go 22.35% <0%> (+5.63%) ⬆️
executor/runtime/docker/capabilities.go 88.88% <0%> (+11.11%) ⬆️
executor/runner/runner.go 60.62% <0%> (+11.87%) ⬆️
executor/runtime/container.go 91.3% <0%> (+13.04%) ⬆️
filesystems/xattr/degrading_utils.go 75% <0%> (+13.63%) ⬆️
filesystems/xattr/degrading_linux.go 89.28% <0%> (+14.28%) ⬆️
executor/drivers/titusdriver.go 84% <0%> (+16%) ⬆️
... and 7 more

@rgulewich rgulewich merged commit 616e642 into master Oct 5, 2018
@rgulewich rgulewich deleted the test-doc-changes branch October 5, 2018 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants