Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Variable log uploading #198

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Variable log uploading #198

merged 1 commit into from
Nov 14, 2018

Conversation

sargun
Copy link
Contributor

@sargun sargun commented Nov 8, 2018

This allows the logging configuration to be changed per container

@coveralls
Copy link

coveralls commented Nov 8, 2018

Pull Request Test Coverage Report for Build 2530

  • 3 of 86 (3.49%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 22.532%

Changes Missing Coverage Covered Lines Changed/Added Lines %
filesystems/watcher.go 3 8 37.5%
executor/mock/jobrunner.go 0 8 0.0%
executor/runner/runner.go 0 17 0.0%
executor/runtime/types/types.go 0 53 0.0%
Totals Coverage Status
Change from base Build 2524: -0.3%
Covered Lines: 2483
Relevant Lines: 11020

💛 - Coveralls

@sargun sargun requested a review from fabiokung November 8, 2018 06:22
@sargun
Copy link
Contributor Author

sargun commented Nov 8, 2018

This was around the ask from NQ of being able to change / configure their logging per-container.

@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #198 into master will decrease coverage by 0.17%.
The diff coverage is 44.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   32.56%   32.38%   -0.18%     
==========================================
  Files          68       68              
  Lines        8593     8627      +34     
==========================================
- Hits         2798     2794       -4     
- Misses       5458     5491      +33     
- Partials      337      342       +5
Impacted Files Coverage Δ
config/config.go 97.23% <ø> (-0.23%) ⬇️
executor/mock/jobrunner.go 76.66% <100%> (+0.15%) ⬆️
filesystems/watcher.go 62% <100%> (ø) ⬆️
executor/runtime/types/types.go 62.85% <26.82%> (-14.93%) ⬇️
executor/runner/runner.go 59.51% <38.46%> (-1.11%) ⬇️

 Make it so that the log uploader can be configured from the container attributes
@sargun sargun merged commit d1eeb96 into master Nov 14, 2018
@sargun sargun deleted the variable-log-uploading branch November 14, 2018 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants