This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sargun
force-pushed
the
optimistic-metadataserver
branch
from
December 1, 2018 00:36
a3927db
to
1544065
Compare
Pull Request Test Coverage Report for Build 2648
💛 - Coveralls |
sargun
force-pushed
the
optimistic-metadataserver
branch
from
December 1, 2018 00:47
1544065
to
81ffa68
Compare
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 32.35% 32.18% -0.17%
==========================================
Files 68 68
Lines 8648 8703 +55
==========================================
+ Hits 2798 2801 +3
- Misses 5508 5557 +49
- Partials 342 345 +3
|
sargun
force-pushed
the
optimistic-metadataserver
branch
6 times, most recently
from
December 1, 2018 02:02
40277bc
to
41d1c38
Compare
* Cleanup titus metadata service init * Make the metadata server us the local region's STS service
sargun
force-pushed
the
optimistic-metadataserver
branch
from
December 1, 2018 02:05
41d1c38
to
df99885
Compare
rgulewich
reviewed
Dec 8, 2018
@@ -380,6 +381,15 @@ func (c *Container) GetKeepLocalFileAfterUpload() (bool, error) { | |||
return strconv.ParseBool(keepLocalFileAfterUploadStr) | |||
} | |||
|
|||
// GetOptimisticIAMTokenFetch indicates whether or not we should delete log files after uploading them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy and pasta?
rgulewich
approved these changes
Dec 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor metadataserver to enable optimistic IAM fetch
This also makes it so that when the metadata server is hit, and it fetches credentials, it'll keep refreshing them automatically, rather than requiring force refresh.