This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Include docker image environment variables back in #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3283
💛 - Coveralls |
sargun
force-pushed
the
dont-crush-peoples-env
branch
from
8863bab
to
a50ab76
Compare
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 35.81% 35.84% +0.03%
==========================================
Files 71 72 +1
Lines 9064 9067 +3
==========================================
+ Hits 3246 3250 +4
Misses 5412 5412
+ Partials 406 405 -1
|
* Factor out environment variable file generation code * Change the way that docker image env variables are added so they don't squash over normal environment variables P.S. Golang has map traversals that are non-deterministic at code authoring time. These tests might break, if that happens because the traversal order might change. If this happens, good luck.
sargun
force-pushed
the
dont-crush-peoples-env
branch
from
a50ab76
to
caf9879
Compare
rgulewich
approved these changes
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so they don't squash over normal environment variables