This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Remove Logging to Journald only under systemd #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that the executor doesn't rely on CGO. It needed cgo before to figure out if it was running as a systemd service or not. This makes it assume it will always run as a systemd service unless otherwise stated by console flags, rather than relying on environment detection.
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
=========================================
+ Coverage 35.18% 35.2% +0.01%
=========================================
Files 77 77
Lines 9521 9517 -4
=========================================
Hits 3350 3350
+ Misses 5753 5749 -4
Partials 418 418
|
rgulewich
reviewed
May 7, 2019
| if debug { | ||
| log.SetLevel(log.DebugLevel) | ||
| } else { | ||
| logsutil.MaybeSetupLoggerIfOnJournaldAvailable() |
There was a problem hiding this comment.
Why do this only when !debug?
There was a problem hiding this comment.
Because if you're running with -debug, you're probably running from the console, and not a service?
rgulewich
approved these changes
May 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that the executor doesn't rely on CGO. It needed
cgo before to figure out if it was running as a systemd service
or not. This makes it assume it will always run as a systemd service
unless otherwise stated by console flags, rather than relying on
environment detection.