Build docker images in Circle CI #95
Conversation
sargun
commented
May 1, 2018
•
sargun
commented
- Use the build docker images from Circle CI builds
- Add code coverage metrics
- Try to collect all of the image builds in one place
sargun
force-pushed
the
build-images
branch
3 times, most recently
from
fdc0e2d
to
3fe3e12
Compare
|
This again requires the "inside" and "outside" GO PATHs to match, but things break under go 1.10 caching (if we share it), and we have a different "inside" and "outside" set of paths. |
| @@ -0,0 +1,29 @@ | |||
| FROM ubuntu:bionic | |||
There was a problem hiding this comment.
This was being built by hand, and uploaded by hand before.
| @@ -0,0 +1,29 @@ | |||
| FROM ubuntu:xenial | |||
There was a problem hiding this comment.
This was being built by hand, and uploaded by hand before.
| @@ -0,0 +1,15 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
This is a combined way to build all the build images.
| @@ -44,4 +44,5 @@ ENV GOPATH /go | |||
| ENV PATH $GOPATH/bin:/usr/local/go/bin:$PATH | |||
There was a problem hiding this comment.
goveralls is to push the reports
| @@ -43,14 +35,16 @@ type testImage struct { | |||
| } | |||
|
|
|||
| var ( | |||
| // TODO: Determine how this got built, and add it to the auto image builders? | |||
There was a problem hiding this comment.
These are all bumped to automated build versions.
| @@ -1 +1,26 @@ | |||
| package standalone | |||
|
|
|||
| make clean | ||
| make --output-sync -j16 builder all 2>&1 | tee build.log | ||
| artifact_paths: "*.log;build/distributions/*.deb;build/distributions/*.tar;build/distributions/*.tar.gz" | ||
| - command: ./.buildkite/build.sh |
There was a problem hiding this comment.
This got moved into a little script
* Use the build docker images from Circle CI builds * Add code coverage metrics
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=========================================
Coverage ? 35.42%
=========================================
Files ? 64
Lines ? 7165
Branches ? 0
=========================================
Hits ? 2538
Misses ? 4327
Partials ? 300
|
|
LGTM @sargun I'm still unsure and 👎 on bind mounting |
|
Getting rid of the data only containers, and sharing caches with the host builds sped things up significantly. Initially doing the test-local, which built the build cache, and then mounting the GOPATH made build times cut down by almost 50%. |
|
If the GOPATH wasn't the same inside and outside of the container, then it wouldn't use the GOPATH. Go seems to freak out whenever it sees bind mounts, or symlinks in gopath. Not sure why. |
