Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force observer and computed methods to be static #30

Closed
theengineear opened this issue May 7, 2019 · 1 comment · Fixed by #69
Closed

Force observer and computed methods to be static #30

theengineear opened this issue May 7, 2019 · 1 comment · Fixed by #69

Comments

@theengineear
Copy link
Collaborator

This is related to #28. Also, it's potentially a nice way for us to remove a fork that may not be providing much benefit.

Benefits to making these static:

  • no chance of naming collision for instance level properties
  • one less fork in our code
  • information can be used in static analysis since it doesn't depend on an instance

Downsides to making these static:

  • a bit more restrictive
  • observer callback may fell a bit less ergonomic since we'll change the call signature

For computed... There's not too much argument here, there should be no need to provide a target. Forcing these methods to be static will also help with potential, future memoization of computations.

For observer... We want to support access to the target still, so we would need to change the signature to be myCallback(target, value, oldValue)--or something like that.

@theengineear
Copy link
Collaborator Author

@klebba , we discussed this at one point as a "funny, terrible idea". I still think the pros outweigh the cons here, but we should have more discussion before implementing.

theengineear added a commit that referenced this issue May 30, 2020
theengineear added a commit that referenced this issue May 30, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 1, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 1, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 2, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 2, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 2, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 3, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 3, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 3, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 3, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 4, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 4, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 6, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 8, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 8, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 9, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 9, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 9, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 10, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 14, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 18, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 19, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 19, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 19, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jun 20, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 2, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 8, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 8, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 10, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 11, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 11, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 12, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 12, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 12, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 16, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 16, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 16, 2020
This closes #57, closes #52, closes #46, closes #42, closes #36,
closes #31, closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 16, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 17, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 17, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 19, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 19, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 19, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 19, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 22, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 22, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 22, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 22, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 24, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Jul 24, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Aug 24, 2020
This closes #57, closes #46, closes #42, closes #36, closes #31,
closes #30, closes #28, closes #26, and closes #25.
theengineear added a commit that referenced this issue Dec 9, 2020
This closes #68, closes #67, closes #66, closes #57, closes #46,
closes #42, closes #36, closes #31, closes #30, closes #28, closes #26,
and closes #25.
theengineear added a commit that referenced this issue Dec 9, 2020
This closes #68, closes #67, closes #66, closes #57, closes #46,
closes #42, closes #36, closes #31, closes #30, closes #28, closes #26,
and closes #25.
theengineear added a commit that referenced this issue Dec 9, 2020
This closes #68, closes #67, closes #66, closes #57, closes #46,
closes #42, closes #36, closes #31, closes #30, closes #28, closes #26,
and closes #25.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant