-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force observer and computed methods to be static #30
Comments
@klebba , we discussed this at one point as a "funny, terrible idea". I still think the pros outweigh the cons here, but we should have more discussion before implementing. |
This was referenced May 7, 2019
theengineear
added a commit
that referenced
this issue
May 30, 2020
theengineear
added a commit
that referenced
this issue
May 30, 2020
theengineear
added a commit
that referenced
this issue
Jun 1, 2020
theengineear
added a commit
that referenced
this issue
Jun 1, 2020
theengineear
added a commit
that referenced
this issue
Jun 2, 2020
theengineear
added a commit
that referenced
this issue
Jun 2, 2020
theengineear
added a commit
that referenced
this issue
Jun 2, 2020
theengineear
added a commit
that referenced
this issue
Jun 3, 2020
theengineear
added a commit
that referenced
this issue
Jun 3, 2020
theengineear
added a commit
that referenced
this issue
Jun 3, 2020
theengineear
added a commit
that referenced
this issue
Jun 3, 2020
theengineear
added a commit
that referenced
this issue
Jun 4, 2020
theengineear
added a commit
that referenced
this issue
Jun 4, 2020
theengineear
added a commit
that referenced
this issue
Jun 6, 2020
theengineear
added a commit
that referenced
this issue
Jun 8, 2020
theengineear
added a commit
that referenced
this issue
Jun 8, 2020
theengineear
added a commit
that referenced
this issue
Jun 9, 2020
theengineear
added a commit
that referenced
this issue
Jun 9, 2020
theengineear
added a commit
that referenced
this issue
Jun 9, 2020
theengineear
added a commit
that referenced
this issue
Jun 10, 2020
theengineear
added a commit
that referenced
this issue
Jun 14, 2020
theengineear
added a commit
that referenced
this issue
Jun 18, 2020
theengineear
added a commit
that referenced
this issue
Jun 19, 2020
theengineear
added a commit
that referenced
this issue
Jun 19, 2020
theengineear
added a commit
that referenced
this issue
Jun 19, 2020
theengineear
added a commit
that referenced
this issue
Jun 20, 2020
theengineear
added a commit
that referenced
this issue
Jul 2, 2020
theengineear
added a commit
that referenced
this issue
Jul 8, 2020
theengineear
added a commit
that referenced
this issue
Jul 8, 2020
theengineear
added a commit
that referenced
this issue
Jul 10, 2020
theengineear
added a commit
that referenced
this issue
Jul 11, 2020
theengineear
added a commit
that referenced
this issue
Jul 11, 2020
theengineear
added a commit
that referenced
this issue
Jul 12, 2020
theengineear
added a commit
that referenced
this issue
Jul 12, 2020
theengineear
added a commit
that referenced
this issue
Jul 12, 2020
theengineear
added a commit
that referenced
this issue
Jul 16, 2020
theengineear
added a commit
that referenced
this issue
Jul 16, 2020
theengineear
added a commit
that referenced
this issue
Jul 16, 2020
theengineear
added a commit
that referenced
this issue
Jul 16, 2020
theengineear
added a commit
that referenced
this issue
Jul 17, 2020
theengineear
added a commit
that referenced
this issue
Jul 17, 2020
theengineear
added a commit
that referenced
this issue
Jul 19, 2020
theengineear
added a commit
that referenced
this issue
Jul 19, 2020
theengineear
added a commit
that referenced
this issue
Jul 19, 2020
theengineear
added a commit
that referenced
this issue
Jul 19, 2020
theengineear
added a commit
that referenced
this issue
Jul 22, 2020
theengineear
added a commit
that referenced
this issue
Jul 22, 2020
theengineear
added a commit
that referenced
this issue
Jul 22, 2020
theengineear
added a commit
that referenced
this issue
Jul 22, 2020
theengineear
added a commit
that referenced
this issue
Jul 24, 2020
theengineear
added a commit
that referenced
this issue
Jul 24, 2020
theengineear
added a commit
that referenced
this issue
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is related to #28. Also, it's potentially a nice way for us to remove a fork that may not be providing much benefit.
Benefits to making these static:
Downsides to making these static:
For
computed
... There's not too much argument here, there should be no need to provide atarget
. Forcing these methods to bestatic
will also help with potential, future memoization of computations.For
observer
... We want to support access to thetarget
still, so we would need to change the signature to bemyCallback(target, value, oldValue)
--or something like that.The text was updated successfully, but these errors were encountered: