Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make internals of x-element #private when support lands in modern browsers. #63

Closed
theengineear opened this issue Aug 24, 2020 · 0 comments · Fixed by #112
Closed

Make internals of x-element #private when support lands in modern browsers. #63

theengineear opened this issue Aug 24, 2020 · 0 comments · Fixed by #112

Comments

@theengineear
Copy link
Collaborator

In #58, we'll be refactoring our code to have a clearer distinction between what is "public facing" and what is "private facing". We've put double underscores in front of methods which we intend to truly internalize later.

Ultimately, this ticket is just a reminder to switch the __ in our code to # when it's supported in browsers we target.
theengineear added a commit that referenced this issue Apr 12, 2022
@theengineear
Leverage class fields and private class fields.
c26c2b4 
The “Class Fields” proposal has been adopted as part of ECMAScript 2022
and tests pass leveraging this feature in Chrome, Firefox, and Safari.

Closes #63.
@theengineear theengineear mentioned this issue Apr 12, 2022
Merged
theengineear added a commit that referenced this issue Apr 13, 2022
@theengineear
Leverage class fields and private class fields.
cc65022 
The “Class Fields” proposal has been adopted as part of ECMAScript 2022
and tests pass leveraging this feature in Chrome, Firefox, and Safari.

Closes #63.
theengineear added a commit that referenced this issue Sep 2, 2022
@theengineear
Leverage class fields and private class fields.
1acbddb 
The “Class Fields” proposal has been adopted as part of ECMAScript 2022
and tests pass leveraging this feature in Chrome, Firefox, and Safari.

Closes #63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Leverage class fields and private class fields. Netflix/x-element
1 participant
@theengineear