zuul-core: Add overload for OriginName trust #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argha-c
reviewed
May 21, 2021
| public OriginName withTrustedAuthority(String authority) { | ||
| return new OriginName(niwsClientName, target, authority, true); | ||
| public static OriginName fromVipAndApp(String vip, String appName) { | ||
| return fromVipAndApp(vip, appName, vip); |
There was a problem hiding this comment.
This isn't obvious without a comment explaining why the vip and niws name may or may not be the same.
There was a problem hiding this comment.
Followed up here: #1067
argha-c
reviewed
May 21, 2021
| @@ -27,13 +26,9 @@ | |||
| @RunWith(JUnit4.class) | |||
| public class OriginNameTest { | |||
There was a problem hiding this comment.
This needs more unit tests, at least:
- verification of equality check
- Tests for when niws name and vip are different
There was a problem hiding this comment.
See above PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.