Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a metric instead of logging excessive filter execution time #1096

Merged
merged 2 commits into from Aug 20, 2021

Conversation

jfernandez
Copy link
Contributor

The information logged here can be useful, but when Zuul slows down these messages will drown out more useful log entries (which may point at the root cause). This data is more useful as a metric.

Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfernandez jfernandez merged commit d66a7c7 into Netflix:master Aug 20, 2021
@jfernandez jfernandez deleted the jose/slowfilter-metrics branch August 20, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants