Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support JDK 17 #1143

Merged
merged 5 commits into from Dec 9, 2021
Merged

support JDK 17 #1143

merged 5 commits into from Dec 9, 2021

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Dec 1, 2021

No description provided.

@sullis
Copy link
Contributor Author

sullis commented Dec 1, 2021 •
edited

JDK 17 build error:

Execution failed for task ':zuul-sample:compileGroovy'.

> BUG! exception in phase 'semantic analysis' in source unit '/home/runner/work/zuul/zuul/zuul-sample/src/main/groovy/com/netflix/zuul/sample/filters/endpoint/Healthcheck.groovy' Unsupported class file major version 61

@sullis
Copy link
Contributor Author

sullis commented Dec 1, 2021

JDK 17 build error:

com.netflix.zuul.netty.server.ssl.SslHandshakeInfoHandlerTest > sslEarlyHandshakeFailure FAILED

    java.security.cert.CertificateException at SslHandshakeInfoHandlerTest.java:51

        Caused by: java.lang.IllegalAccessError at SslHandshakeInfoHandlerTest.java:51

@sullis sullis changed the title chore(ci): JDK 17 support JDK 17 Dec 2, 2021
@sullis
Copy link
Contributor Author

sullis commented Dec 2, 2021

ready for review @carl-mastrangelo @argha-c

@sullis
Copy link
Contributor Author

sullis commented Dec 4, 2021

I rebased against master. Everything LGTM.

@carl-mastrangelo
Copy link
Contributor

@sullis I changed teams a few months ago and am no longer working on Zuul.

cc @artgon

@sullis
Copy link
Contributor Author

sullis commented Dec 6, 2021

wdyt? @argha-c

argha-c
argha-c approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@argha-c argha-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build looks fine. LGTM

@sullis
Copy link
Contributor Author

sullis commented Dec 9, 2021

Ready to merge. @argha-c @DanielThomas

@argha-c argha-c merged commit 1697e0c into Netflix:master Dec 9, 2021
@sullis sullis deleted the jdk-17-sean branch December 9, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argha-c argha-c argha-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sullis @carl-mastrangelo @argha-c