Add a new handler to close on inbound http/2 protocol errors #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguerra
requested review from
gavinbunney,
argha-c,
kyagna and
lindseyreynolds
argha-c
reviewed
Nov 15, 2023
|
|
||
| @Override | ||
| public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception { | ||
| if(cause instanceof Http2Exception http2Exception && http2Exception.shutdownHint() == Http2Exception.ShutdownHint.HARD_SHUTDOWN) { |
There was a problem hiding this comment.
The Http2ConnectionHandler has a generic mechanism to send GO_AWAY frames and close on connection errors.
Is that not kicking in here or are we trying to address specific cases that aren't flagged via that mechanism?
There was a problem hiding this comment.
I missed that subtlety. Http2FrameCodec calls fireExceptionCaught (what this PR is intended to address) and then after that Http2ConnectionHandler.onConnectionError. I'll rework this PR to just capture metrics
argha-c
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles
closing the connectionlogging/counting malformed requests like invalid hpack, or invalid stream numbers.