Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append a legal note to sent messages for Email 2 #5452

Closed
DavidePrincipi opened this issue Apr 11, 2018 · 13 comments
Closed

Append a legal note to sent messages for Email 2 #5452

DavidePrincipi opened this issue Apr 11, 2018 · 13 comments
Labels
verified All test cases were verified successfully
Projects
NethServer 7
Milestone
v7

Comments

@DavidePrincipi
Copy link
Member

The "Append a legal note to sent messages" implemented with amavisd/altermime in nethserver-mail-common must be ported to the new rspamd-based mail2 implementation, retaining backward compatibility.

See also

https://community.nethserver.org/t/nethserver-rspamd-a-new-module/8485/17
@DavidePrincipi DavidePrincipi added this to the v7 milestone Apr 11, 2018
@DavidePrincipi DavidePrincipi self-assigned this Apr 11, 2018
@DavidePrincipi DavidePrincipi added this to ✋ Needs review in NethServer 7 via automation Apr 11, 2018
@stephdl stephdl mentioned this issue Apr 11, 2018
Merged
DavidePrincipi added a commit to NethServer/nethserver-mail that referenced this issue Apr 11, 2018
@DavidePrincipi
Merge pull request #6 from stephdl/disclaimerByAltermime
592fbaf 
Disclaimer by altermime

NethServer/dev#5452
@nethbot
Copy link
Member

nethbot commented Apr 11, 2018

in 7.4.1708/testing:

This was referenced Apr 11, 2018
Merged
Merged
DavidePrincipi added a commit to NethServer/nethserver-mail that referenced this issue Apr 11, 2018
@DavidePrincipi
Update upgrade procedures for disclaimer
8ad7dad 
Provide nethserver-mail-disclaimer symbol for future RPM automated upgrade

NethServer/dev#5452
@nethbot
Copy link
Member

nethbot commented Apr 11, 2018

in 7.4.1708/testing:

@DavidePrincipi DavidePrincipi mentioned this issue Apr 11, 2018
Merged
@nethbot
Copy link
Member

nethbot commented Apr 11, 2018

in 7.4.1708/testing:

@DavidePrincipi DavidePrincipi added the testing Packages are available from testing repositories label Apr 11, 2018
@DavidePrincipi
Copy link
Member Author

Test case

  • Check the "Append a legal note to sent messages" is not available if nethserver-mail2-disclaimer is not installed
  • Install nethserver-mail2-disclaimer
  • Check disclaimer is appended as usual to outbound messages. Only submissions port have disclaimer feature (not compatible with legacy policy, that enables SMTP/AUTH on port 25)

@DavidePrincipi DavidePrincipi removed their assignment Apr 11, 2018
@DavidePrincipi DavidePrincipi moved this from ✋ Needs review to ⚙ Developing in NethServer 7 Apr 12, 2018
@gsanchietti
Copy link
Member

Tested using a rely server and sending with mail with curl.

@gsanchietti gsanchietti added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Apr 13, 2018
@stephdl
Copy link

stephdl commented Apr 14, 2018

ola sorry but we have an error in /var/log/messages

Unquoted string "break" may clash with future reserved word at /etc/e-smith/templates//etc/postfix/master.cf/01TemplateDisclaimer_vars line 13
in fact break is not used in perl it is last

@stephdl stephdl added testing Packages are available from testing repositories and removed verified All test cases were verified successfully labels Apr 14, 2018
@stephdl stephdl mentioned this issue Apr 14, 2018
Merged
DavidePrincipi pushed a commit to NethServer/nethserver-mail that referenced this issue Apr 15, 2018
@stephdl @DavidePrincipi
Replace break by last (#39)
6672d4c 
Replace break by last NethServer/dev#5452
@nethbot
Copy link
Member

nethbot commented Apr 15, 2018

in 7.4.1708/testing:

DavidePrincipi added a commit to NethServer/docs that referenced this issue Apr 15, 2018
@DavidePrincipi
Email 2 upgrade for disclaimer component (#299)
0af2cc0 
NethServer/dev#5452
DavidePrincipi added a commit to NethServer/nethserver-mail-common that referenced this issue Apr 15, 2018
@DavidePrincipi
Add nethserver-mail-disclaimer RPM placeholder (#19)
7f7b819 
NethServer/dev#5452
@nethbot
Copy link
Member

nethbot commented Apr 15, 2018

in 7.4.1708/testing:

@stephdl
Copy link

stephdl commented Apr 16, 2018 •
edited

no more errors in /var/log/messages, set verified

Apr 16 10:12:50 prometheus esmith::event[26403]: Event: domain-modify ola.org
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/opendkim.conf
Apr 16 10:12:50 prometheus dbus[645]: [system] Activating via systemd: service name='org.freedesktop.timedate1' unit='dbus-org.freedesktop.timedate1.service'
Apr 16 10:12:50 prometheus dbus-daemon: dbus[645]: [system] Activating via systemd: service name='org.freedesktop.timedate1' unit='dbus-org.freedesktop.timedate1.service'
Apr 16 10:12:50 prometheus systemd: Starting Time & Date Service...
Apr 16 10:12:50 prometheus dbus[645]: [system] Successfully activated service 'org.freedesktop.timedate1'
Apr 16 10:12:50 prometheus dbus-daemon: dbus[645]: [system] Successfully activated service 'org.freedesktop.timedate1'
Apr 16 10:12:50 prometheus systemd: Started Time & Date Service.
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/postfix/internal_access
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/postfix/recipient_bcc
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/postfix/virtual
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/postfix/main.cf
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/postfix/master.cf
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/postfix/transport
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/postfix/disclaimer
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/dovecot/dovecot.conf
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/opendkim/KeyTable
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/opendkim/SigningTable
Apr 16 10:12:50 prometheus esmith::event[26403]: expanding /etc/opendkim/TrustedHosts
Apr 16 10:12:50 prometheus esmith::event[26403]: Action: /etc/e-smith/events/actions/generic_template_expand SUCCESS [0.491566]
Apr 16 10:12:52 prometheus esmith::event[26403]: Action: /etc/e-smith/events/domain-modify/S30nethserver-mail-postmap-update SUCCESS [1.734704]
Apr 16 10:12:52 prometheus systemd: Reloading.
Apr 16 10:12:52 prometheus esmith::event[26403]: [INFO] service dovecot reload
Apr 16 10:12:52 prometheus systemd: Reloaded Dovecot IMAP/POP3 email server.
Apr 16 10:12:52 prometheus systemd: Reloading.
Apr 16 10:12:52 prometheus esmith::event[26403]: [INFO] service memcached restart
Apr 16 10:12:52 prometheus systemd: Stopping Memcached...
Apr 16 10:12:52 prometheus systemd: Started Memcached.
Apr 16 10:12:52 prometheus systemd: Starting Memcached...
Apr 16 10:12:52 prometheus systemd: Reloading.
Apr 16 10:12:53 prometheus esmith::event[26403]: [INFO] service postfix restart
Apr 16 10:12:53 prometheus systemd: Stopping Postfix Mail Transport Agent...
Apr 16 10:12:53 prometheus systemd: Starting Postfix Mail Transport Agent...
Apr 16 10:12:53 prometheus systemd: Started Postfix Mail Transport Agent.
Apr 16 10:12:53 prometheus systemd: Reloading.
Apr 16 10:12:53 prometheus esmith::event[26403]: [INFO] service opendkim restart
Apr 16 10:12:53 prometheus systemd: Stopping DomainKeys Identified Mail (DKIM) Milter...
Apr 16 10:12:55 prometheus systemd: Starting DomainKeys Identified Mail (DKIM) Milter...
Apr 16 10:12:55 prometheus systemd: Started DomainKeys Identified Mail (DKIM) Milter.
Apr 16 10:12:55 prometheus esmith::event[26403]: Action: /etc/e-smith/events/actions/adjust-services SUCCESS [2.639013]
Apr 16 10:12:55 prometheus esmith::event[26403]: Event: domain-modify SUCCESS

@stephdl stephdl added the verified All test cases were verified successfully label Apr 16, 2018
@stephdl stephdl removed the testing Packages are available from testing repositories label Apr 16, 2018
@nethbot
Copy link
Member

nethbot commented Apr 16, 2018

in 7.4.1708/testing:

@nethbot
Copy link
Member

nethbot commented Apr 17, 2018

in 7.4.1708/testing:

@nethbot
Copy link
Member

nethbot commented Apr 17, 2018

in 7.4.1708/updates:

@nethbot
Copy link
Member

nethbot commented Apr 17, 2018

in 7.4.1708/updates:

NethServer 7 automation moved this from ⚙ Developing to 🗑 Done Apr 17, 2018
DavidePrincipi added a commit to NethServer/comps that referenced this issue Apr 17, 2018
@DavidePrincipi
Optional mail2-disclaimer in Email 2 group (#8)
169f20d 
NethServer/dev#5452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
verified All test cases were verified successfully
Projects
No open projects
NethServer 7
🗑 Done
Milestone
v7
Development

No branches or pull requests
4 participants
@gsanchietti @DavidePrincipi @stephdl @nethbot