SSH Save button stuck after update

[DavidePrincipi]

After an update the Save button of Cockpit System > SSH page does not work any more.

Steps to reproduce

1. install and configure a local LDAP accounts provider (I guess this is not a strict requirement but doesn’t harm)
2. go to Software Center and update nethserver-cockpit (1.4.4 => 1.4.5) and nethserver-openssh (1.4.0 => 1.4.1)
3. go immediately to the SSH Cockpit UI and press Save
4. log out
5. log in again and go back to SSH Cockpit UI. Save button does not work any more.

Expected behavior

The Save button applies the UI state and runs the *-save event.

Actual behavior

A spinner appears for a while, then nothing else happens. In the browser console:

API exec: system-openssh/validate
$  echo '{"name":"sshd","props":{"PasswordAuthentication":"yes","PermitRootLogin":"yes","TCPPort":"22","AllowGroups":{},"AllowEveryone":""},"type":"service"}' | /usr/bin/sudo /usr/libexec/nethserver/api/system-openssh/validate | jq

In the config DB, after step 3:

[root@vm5 ~]# config show sshd
sshd=service
    AllowEveryone=
    AllowGroups=
    LoginGraceTime=2m
    MaxAuthTries=6
    PasswordAuthentication=yes
    PermitRootLogin=yes
    Protocol=2
    SubsystemSftp=yes
    TCPPort=22
    UsePAM=yes
    access=green,red
    status=enabled

In /var/log/messages:

Mar  2 09:37:45 vm5 /usr/libexec/nethserver/api/system-openssh/update[19875]: /var/lib/nethserver/db/configuration: OLD sshd=service|AllowEveryone|none|AllowGroups||LoginGraceTime|2m|MaxAuthTries|6|PasswordAuthentication|yes|PermitRootLogin|yes|Protocol|2|SubsystemSftp|yes|TCPPort|22|UsePAM|yes|access|green,red|status|enabled
Mar  2 09:37:45 vm5 /usr/libexec/nethserver/api/system-openssh/update[19875]: /var/lib/nethserver/db/configuration: NEW sshd=service|AllowEveryone||AllowGroups||LoginGraceTime|2m|MaxAuthTries|6|PasswordAuthentication|yes|PermitRootLogin|yes|Protocol|2|SubsystemSftp|yes|TCPPort|22|UsePAM|yes|access|green,red|status|enabled

Components

• nethserver-openssh-1.4.1-1.ns7.noarch
• nethserver-cockpit-1.4.5-1.ns7.noarch

See also

The bug was initially discovered and analyzed here

https://community.nethserver.org/t/ssh-unable-to-save-changes-from-cockpit-ui/14808

---

Thanks to @dnutan and @stephdl for their help!

[DavidePrincipi]

Workaround

Please see the solution in the community forum post linked above.

[nethbot]

in 7.7.1908/testing:

• nethserver-cockpit-1.4.5-1.1.gb4ee2cd.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-cockpit-lib-1.4.5-1.1.gb4ee2cd.ns7.noarch.rpm x86_64 armhfp aarch64

[stephdl]

TESTING (Failed ?)

I think I cannot reproduce, at least no error in console and the UI sends the good API, however you protected the props, but I think you missed AllowGroups.

Please check https://community.nethserver.org/t/ssh-unable-to-save-changes-from-cockpit-ui/14808/3 at the beginning the errors came for it, see L42

[DavidePrincipi]

Please see my review comment.

Reproducing the issue is not easy. Did you follow the steps starting from a clean system?

[stephdl]

I did a full update on friday, all my VM are already updated to the last nethserver-cockpit & nethserver-openssh

[nethbot]

in 7.7.1908/testing:

• nethserver-cockpit-1.4.5-1.4.gdabd5fb.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-cockpit-lib-1.4.5-1.4.gdabd5fb.ns7.noarch.rpm x86_64 armhfp aarch64

[nethbot]

in 7.7.1908/testing:

• nethserver-cockpit-1.4.5-1.5.g42d63a9.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-cockpit-lib-1.4.5-1.5.g42d63a9.ns7.noarch.rpm x86_64 armhfp aarch64

[stephdl]

verified

if the UI doesn't send what the API expects, the props are not saved

[nethbot]

in 7.7.1908/updates:

• nethserver-cockpit-1.4.6-1.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-cockpit-lib-1.4.6-1.ns7.noarch.rpm x86_64 armhfp aarch64