OpenVPN: custom mail text

[gsanchietti]

The OpenVPN UI allows to send the client configuration directly to users by mail.
Currently, the text of the mail is fixed but some users may require changing it.

Proposed solution

Add a configuration file to allow changing the mail text.

[nethbot]

in 7.8.2003/testing:

• nethserver-vpn-ui-1.5.0-1.1.ga2f2c7b.ns7.noarch.rpm x86_64 armhfp aarch64

[gsanchietti]

Test case 1

• Configure a machine with at lease one OpenVPN user
• Send the configuration by mail from the UI
• Upgrade the machine
• Re-send the configuration by mail from the UI, verify the text of the mail is unchanged

Test case 2

• Create the /etc/nethserver/openvpn-mail.cfg and put some text on it
• Send the configuration by mail from the UI, verify the mail contains the new text

QA note: more about configuration file format available inside the README

[cotosso]

Test case 1: ok
Test case 2: it seems to be ok, but I also tried to use the $name variable in the email text.
If I use the $name variable more than once in the text it's expanded only the first time, e.g.

mio $name
mio $name
mio $name

becomes in the email text

mio ACCOUNTNAME
mio $name
mio $name

is that normal?

[nethbot]

in 7.8.2003/testing:

• nethserver-vpn-ui-1.5.0-1.2.gc1faa3d.ns7.noarch.rpm x86_64 armhfp aarch64

[gsanchietti]

is that normal?

Yes, the code was implemented to fit current usage scenario.
Still, I made a modification to fit your expectations.

Could you please check again @cotosso ?

[cotosso]

I just checked and now it works as expected

[nethbot]

in 7.8.2003/updates:

• nethserver-vpn-ui-1.5.1-1.ns7.noarch.rpm x86_64 armhfp aarch64