Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mail: can't set custom mailbox quota #6197

Closed
gsanchietti opened this issue Jun 10, 2020 · 6 comments
Closed

Mail: can't set custom mailbox quota #6197

gsanchietti opened this issue Jun 10, 2020 · 6 comments
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@gsanchietti
Copy link
Member

On old machines migrated from NS 6 and configured with the old Server Manager, the administrator can't set a custom mailbox quota.

Steps to reproduce

  • Install a machine and call it mail.nstest.org
  • Configure a server with OpenLDAP (or AD) and create the user test
  • Install the mail server
  • Try to set the custom mailbox quota
  • Create a special crafted record to simulate the old machine: 
    echo 'test@nstest.org=user|MailAccess|public|MailForwardAddress||MailForwardKeepMessageCopy|no|MailForwardStatus|disabled|MailQuotaCustom|100|MailQuotaType|custom|MailSpamRetentionStatus|disabled|MailStatus|enabled' >> /var/lib/nethserver/db/accounts
    The resulting record user must not have the MailSpamRetentionTime

Expected behavior

The mail quota should be editable.

Actual behavior

After setting a custom mail quota, the UI is stuck on validation but it reports nothing.
Screenshot:
Screenshot from 2020-06-10 14-50-50

Check the API from CLI:

#  echo '{"MailForwardAddress":[],"MailSpamRetentionStatus":"disabled","MailQuotaCustom":22,"MailForwardKeepMessageCopy":"no","MailQuotaType":"custom","MailForwardStatus":"disabled","MailSpamRetentionTime":"","MailStatus":"enabled","name":"test@nstest.org","action":"update-user"}' | /usr/libexec/nethserver/api/nethserver-mail/mailbox/validate | jq

Actual output:

{
  "type": "NotValid",
  "message": "validation_failed",
  "attributes": [
    {
      "parameter": "MailSpamRetentionTime",
      "value": "",
      "error": "valid_integer"
    }
  ]
}

Components

nethserver-mail-common-2.15.0-1.ns7.noarch
@gsanchietti gsanchietti added the bug A defect of the software label Jun 10, 2020
@gsanchietti gsanchietti mentioned this issue Jun 10, 2020
Merged
gsanchietti added a commit to NethServer/nethserver-mail that referenced this issue Jun 10, 2020
@gsanchietti
api: prevent validation of non-existing parameter (#205)
802256f 
NethServer/dev#6197
@nethbot
Copy link
Member

nethbot commented Jun 10, 2020

in 7.8.2003/testing:

@gsanchietti
Copy link
Member Author

Test case
Check the bug is not reproducible

@gsanchietti gsanchietti added the testing Packages are available from testing repositories label Jun 10, 2020
@nethbot
Copy link
Member

nethbot commented Jun 12, 2020

in 7.8.2003/testing:

@nrauso nrauso self-assigned this Jun 12, 2020
@nrauso
Copy link

nrauso commented Jun 12, 2020

tested: verified

custom quota works flawlessly

@nrauso nrauso added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Jun 12, 2020
@nethbot
Copy link
Member

nethbot commented Jun 15, 2020

in 7.8.2003/testing:

@nethbot
Copy link
Member

nethbot commented Jun 16, 2020

in 7.8.2003/updates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gsanchietti @nrauso @nethbot