Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imapsync: handle password with special chars #6233

Closed
gsanchietti opened this issue Jul 17, 2020 · 4 comments
Closed

Imapsync: handle password with special chars #6233

gsanchietti opened this issue Jul 17, 2020 · 4 comments
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@gsanchietti
Copy link
Member

Some special chars on password may prevent a correct imapsync execution.

From https://imapsync.lamiral.info/FAQ.d/FAQ.Passwords_on_Unix.txt:

Q. On Unix, some passwords contain some weird *(),;&~ characters.
Login fails.
...
R2. If R1 fails, with very old imapsync or old Mail::IMAPClient Perl module,
try also using double-quotes within single-quotes. It will enclose
the password within double-quotes in the imap LOGIN command:

Steps to reproduce

  • Access the IMAP sync page
  • Configure a remote user where the password is like MyPass* (the asterisk chat must be last one)
  • Execute the sync

Expected behavior

The sync should start.

Actual behavior

The sync is not started due to a bug in perl-IMAPClient package. From the above FAQ:

Old Mail::IMAPClient 3.37 is a bad horse having this issue solved
by this double-quotes trick.
fixed in 3.38 https://metacpan.org/changes/distribution/Mail-IMAPClient

EPEL ships the bugged version: Mail::IMAPClient 3.37

Components

nethserver-mail-imapsync-2.17.0

Thanks to nrauso
@gsanchietti gsanchietti added the bug A defect of the software label Jul 17, 2020
@gsanchietti gsanchietti mentioned this issue Jul 17, 2020
Merged
gsanchietti added a commit to NethServer/nethserver-mail that referenced this issue Jul 17, 2020
@gsanchietti
imapsync: workaround IMAPClient password bug (#212)
1e97073 
From imapsync FAQ:

 Q. On Unix, some passwords contain some weird *(),;&~ characters.
   Login fails.
 ...
 R2. If R1 fails, with very old imapsync or old Mail::IMAPClient Perl module,
    try also using double-quotes within single-quotes. It will enclose
    the password within double-quotes in the imap LOGIN command:

The fix has been released on Mail::IMAPClient 3.38, while EPEL has 3.37
release

NethServer/dev#6233
@nethbot
Copy link
Member

nethbot commented Jul 17, 2020

in 7.8.2003/testing:

@gsanchietti
Copy link
Member Author

Test case
Check the bug is not reproducible

@gsanchietti gsanchietti added the testing Packages are available from testing repositories label Jul 17, 2020
@nrauso nrauso self-assigned this Jul 20, 2020
@nrauso
Copy link

nrauso commented Jul 20, 2020

tested: verified

Now profiles with password containing "weird" chars are correctly synced.

@nrauso nrauso removed their assignment Jul 20, 2020
@nrauso nrauso added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Jul 20, 2020
@nethbot
Copy link
Member

nethbot commented Jul 20, 2020

in 7.8.2003/updates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gsanchietti @nrauso @nethbot