Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cockpit: minor cosmetic issues in web filter #6259

Closed
filippocarletti opened this issue Aug 27, 2020 · 7 comments
Closed

Cockpit: minor cosmetic issues in web filter #6259

filippocarletti opened this issue Aug 27, 2020 · 7 comments
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@filippocarletti
Copy link
Member

There are 4 minor issues in the cockpit web interface of the web filter:

  1. The "Clear all" link in a filter profile is too wide, it may be clicked involuntarily
  2. The list of categories is changed even after clicking Cancel
  3. Sometimes the list of categories is empty (reload to fix)
  4. Sometimes the page is not displayed (spinner forever, reload fixes)

Steps to reproduce

  • 3 and 4 are not easily reproducible
  • 4 seen only on chrome (firefox seems ok)

Notes:
Point #2: also the block extensions option is remembered after clicking Cancel
Point #4: chrome console shows:

dygraph.js:142 Uncaught Error: Constructing dygraph with a non-existent div!
    at L.__init__ (dygraph.js:142)
    at new L (dygraph.js:88)
    at Dashboard.vue:579
    at Function.<anonymous> (nethserver.js:108)
    at s (cockpit.js:962)
    at cockpit.js:974
    at n (cockpit.js:880)
@filippocarletti filippocarletti added the bug A defect of the software label Aug 27, 2020
andre8244 added a commit to andre8244/nethserver-squid that referenced this issue Aug 31, 2020
Reset default profile changes if user presses Cancel button
NethServer/dev#6259
@andre8244
Copy link
Contributor

Points #1 and #2 should be fixed. Unfortunately, I couldn't reproduce points #3 and #4

edospadoni pushed a commit to NethServer/nethserver-squid that referenced this issue Aug 31, 2020
@andre8244 andre8244 added the testing Packages are available from testing repositories label Aug 31, 2020
@nethbot
Copy link
Member

nethbot commented Aug 31, 2020

in 7.8.2003/testing:

@andre8244
Copy link
Contributor

Test case

  • Verify correct behavior for points #1 and #2

@stephdl
Copy link

stephdl commented Aug 31, 2020

QA

#1 and #2 are good

@stephdl stephdl self-assigned this Aug 31, 2020
@gsanchietti
Copy link
Member

Since the fix is only for 1 and 2, can we set this to verified @filippocarletti ?

@filippocarletti
Copy link
Member Author

After updating to chrome 85.0.4183.83 I've no longer seen issue 3 and 4.

@gsanchietti gsanchietti added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Sep 2, 2020
@nethbot
Copy link
Member

nethbot commented Sep 2, 2020

in 7.8.2003/updates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Development

No branches or pull requests

5 participants