Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVPN RW: certificate not created if account name contains key spaces #6336

Closed
cotosso opened this issue Nov 18, 2020 · 5 comments
Closed
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@cotosso
Copy link

cotosso commented Nov 18, 2020

Steps to reproduce

OpenVPN RoadWarrior section

  • Create a new account with (at least) a key space in it (e.g. "nome spazio")

Expected behavior

New account certificate is created flawlessy

Actual behavior

New account certificate is not created, we can clearly see it in logs:

...
...
...
Nov 18 11:23:55 nsec /usr/libexec/nethserver/api/nethserver-vpn-ui/openvpn-rw/create[8367]: /var/lib/nethserver/db/vpn: OLD nome spazio=vpn|OpenVpnIp||VPNRemoteNetmask||status|enabled
Nov 18 11:23:55 nsec /usr/libexec/nethserver/api/nethserver-vpn-ui/openvpn-rw/create[8367]: /var/lib/nethserver/db/vpn: NEW nome spazio=vpn|OpenVpnIp||VPNRemoteNetmask||VPNRemoteNetwork||sta
tus|enabled
Nov 18 11:23:56 nsec cockpit-bridge: unknown option spazio.key
Nov 18 11:23:56 nsec cockpit-bridge: req [options] <infile >outfile
...
...
...
Nov 18 11:23:56 nsec cockpit-bridge: -nameopt arg    - various certificate name options
Nov 18 11:23:56 nsec cockpit-bridge: -reqopt arg    - various request text options
Nov 18 11:23:56 nsec cockpit-bridge: Can't create CSR for nome spazio certificate!

Components

NethServer release 7.8.2003 (final)

nethserver-vpn-ui-1.5.3-1.ns7.noarch
nethserver-openvpn-1.12.1-1.ns7.noarch
openvpn-2.4.9-1.el7.x86_64

@cotosso cotosso added the bug A defect of the software label Nov 18, 2020
@stephdl
Copy link

stephdl commented Nov 19, 2020

No problem I am on it

stephdl added a commit to NethServer/nethserver-vpn-ui that referenced this issue Nov 19, 2020
Create a validator for VPN only name with R2W NethServer/dev#6336
@nethbot
Copy link
Member

nethbot commented Nov 19, 2020

in 7.9.2009/testing:

@stephdl
Copy link

stephdl commented Nov 19, 2020

QA

After the upgrade

create a VPN-only certificate, the (space) is not more allowed, we use the validator of USERNAME
create a VPN user certificate, you must create it as usual from the dropdown with the list of user

@stephdl stephdl removed their assignment Nov 19, 2020
@stephdl stephdl added the testing Packages are available from testing repositories label Nov 19, 2020
@cotosso
Copy link
Author

cotosso commented Nov 19, 2020

tested and works as expected.

@cotosso cotosso added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Nov 19, 2020
@nethbot
Copy link
Member

nethbot commented Nov 19, 2020

in 7.9.2009/updates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Development

No branches or pull requests

4 participants