Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nethserver-dedalo: Ethernet offload is still active if a vlan is used as hotspot interface #6343

Closed
Amygos opened this issue Nov 23, 2020 · 5 comments
Closed

nethserver-dedalo: Ethernet offload is still active if a vlan is used as hotspot interface #6343

Amygos opened this issue Nov 23, 2020 · 5 comments
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@Amygos
Copy link
Member

Amygos commented Nov 23, 2020

Steps to reproduce

  1. Create a VLAN
  2. Configure the captive portal to use the just created VLAN as hotspot' interface.
  3. Check the Ethernet offloads status on the physical interface. (eg. ethtool -k enp1s0 | grep offload)

Expected behavior

The Ethernets Offloads on the physical interface must be disabled.

Actual behavior

The Ethernets Offloads are still enabled:

[root@nsec-primary ~]# ethtool -k enp1s0| grep offload
tcp-segmentation-offload: on
udp-fragmentation-offload: off [fixed]
generic-segmentation-offload: on
generic-receive-offload: on
large-receive-offload: off [fixed]
rx-vlan-offload: on
tx-vlan-offload: on
l2-fwd-offload: off [fixed]
hw-tc-offload: on
rx-udp_tunnel-port-offload: off [fixed]

Components

  • nethserver-dedalo

See also

#6264
@Amygos Amygos added the bug A defect of the software label Nov 23, 2020
@Amygos Amygos mentioned this issue Nov 23, 2020
Merged
Amygos added a commit to NethServer/nethserver-dedalo that referenced this issue Nov 26, 2020
@Amygos
Merge pull request #32 from Amygos/master
aa2e0bf 
dedalo: disable offloads also when a vlan is used
NethServer/dev#6343
@nethbot
Copy link
Member

nethbot commented Nov 26, 2020

in 7.9.2009/testing:

@Amygos Amygos added the testing Packages are available from testing repositories label Nov 26, 2020
@Amygos
Copy link
Member Author

Amygos commented Nov 26, 2020

Test case

  • Check the bug is not reproducible

@cotosso
Copy link

cotosso commented Nov 26, 2020

bug is not reproducible :
BEFORE

[root@fw ~]# ethtool -k enp1s0| grep offload
tcp-segmentation-offload: on
udp-fragmentation-offload: off [fixed]
generic-segmentation-offload: on
generic-receive-offload: on
large-receive-offload: off [fixed]
AFTER
[root@fw ~]# ethtool -k enp1s0| grep offload
tcp-segmentation-offload: off
udp-fragmentation-offload: off [fixed]
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off [fixed]

@cotosso cotosso added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Nov 26, 2020
@nethbot
Copy link
Member

nethbot commented Nov 26, 2020

in 7.9.2009/testing:

@nethbot
Copy link
Member

nethbot commented Nov 27, 2020

in 7.9.2009/updates:

@Amygos Amygos closed this as completed Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Amygos @cotosso @nethbot