Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mattermost: push notification server overwritten by update #6489

Closed
gsanchietti opened this issue Apr 19, 2021 · 4 comments
Closed

Mattermost: push notification server overwritten by update #6489

gsanchietti opened this issue Apr 19, 2021 · 4 comments
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@gsanchietti
Copy link
Member

Everytime mattermost is updated, the push notification server gets overridden.

Steps to reproduce

  • Install mattermost and configure the push notification server
  • Execute: signal-event nethserver-mattermost-update

Expected behavior

The push notification and other initial options should not be overridden.

Actual behavior

The push notification server get overridden.
This is due to this commit: NethServer/nethserver-mattermost@5f7f336

Mattermost changes the Directory option by adding a trailing slash to it:

[root@ns7 ~]# /etc/e-smith/events/actions/nethserver-mattermost-conf-json
[root@ns7 ~]#  cat /opt/mattermost/config/config.json | jq '.FileSettings.Directory'
"/var/lib/nethserver/mattermost/data"
[root@ns7 ~]# systemctl restart mattermost
[root@ns7 ~]#  cat /opt/mattermost/config/config.json | jq '.FileSettings.Directory'
"/var/lib/nethserver/mattermost/data/"

So this condition is never met.

Components

nethserver-mattermost

@gsanchietti gsanchietti added the bug A defect of the software label Apr 19, 2021
gsanchietti added a commit to NethServer/nethserver-mattermost that referenced this issue Apr 19, 2021
@nethbot
Copy link
Member

nethbot commented Apr 19, 2021

in 7.9.2009/testing:

  • nethserver-mattermost-1.6.5-1.4.gc2c3f95.ns7.x86_64.rpm x86_64

@gsanchietti
Copy link
Member Author

Test case
Check the issue is not reproducible

@gsanchietti gsanchietti added the testing Packages are available from testing repositories label Apr 19, 2021
@nrauso nrauso self-assigned this Apr 19, 2021
@nrauso
Copy link

nrauso commented Apr 19, 2021

Test case: VERIFIED

Now the push notification server is not overwritten when mattermost events are executed.

@nrauso nrauso removed their assignment Apr 19, 2021
@nrauso nrauso added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Apr 19, 2021
@nethbot
Copy link
Member

nethbot commented Apr 19, 2021

in 7.9.2009/updates:

  • nethserver-mattermost-1.6.6-1.ns7.x86_64.rpm x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Development

No branches or pull requests

3 participants