mail filter antivirus ignores size and action settings

[filippocarletti]

We have options to reject (or mark as spam) mails containing a virus and to avoid scanning big files, setting a limit on the attachment size to send to the antivirus engine.
These options are ignored.

Steps to reproduce

• config setprop rspamd VirusScanSize 99999
• signal-event nethserver-mail-filter-update
• grep max_size /etc/rspamd/local.d/antivirus.conf

Expected behavior

max_size = 99999;

Actual behavior

max_size = 20000000;

Components

nethserver-mail-filter-2.30.0-1.ns7.noarch

[filippocarletti]

Both props are speeled incorrectly in the template:

my $action = $rspamd{'antivirusAction'} || 'reject';
my $scanSize = $rspamd{'antivirusScanSize'} || '20000000';

~]# config show rspamd | grep Virus
    VirusAction=reject
    VirusCheckStatus=enabled
    VirusScanOnlyAttachment=false
    VirusScanSize=2000000

[stephdl]

indeed

[root@prometheus ~]# grep -srni 'VirusScanSize' /etc/e-smith/templates
/etc/e-smith/templates/etc/rspamd/local.d/antivirus.conf/10base:3:my $scanSize = $rspamd{'antivirusScanSize'} || '20000000';
/etc/e-smith/templates/etc/rspamd/local.d/external_services.conf/10base:26:  max_size = $rspamd{'VirusScanSize'};\n";
[root@prometheus ~]# grep -srni 'VirusScanSize' /usr/libexec/nethserver/api/
/usr/libexec/nethserver/api/nethserver-mail/filter/validate:39:    $v->declareParameter('VirusScanSize', Validate::POSITIVE_INTEGER);

and

[root@prometheus ~]# grep -srni 'virusAction' /etc/e-smith/templates
/etc/e-smith/templates/etc/rspamd/local.d/antivirus.conf/10base:2:my $action = $rspamd{'antivirusAction'} || 'reject';

[nethbot]

in 7.9.2009/testing:

• nethserver-mail-common-2.30.0-1.2.g354f910.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-disclaimer-2.30.0-1.2.g354f910.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-filter-2.30.0-1.2.g354f910.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-getmail-2.30.0-1.2.g354f910.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-imapsync-2.30.0-1.2.g354f910.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-ipaccess-2.30.0-1.2.g354f910.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-p3scan-2.30.0-1.2.g354f910.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-quarantine-2.30.0-1.2.g354f910.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-server-2.30.0-1.2.g354f910.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-smarthost-2.30.0-1.2.g354f910.ns7.noarch.rpm x86_64 armhfp aarch64

[gsanchietti]

Test case
Check the issue is not reproducible

[lucagasparini]

Before updating:

rpm -qa|grep nethserver-mail

nethserver-mail-filter-2.30.0-1.ns7.noarch
nethserver-mail-common-2.30.0-1.ns7.noarch
nethserver-mail-smarthost-2.30.0-1.ns7.noarch
nethserver-mail-server-2.30.0-1.ns7.noarch

~]#  config getprop rspamd VirusScanSize
20000000

config setprop rspamd VirusScanSize 99999
signal-event nethserver-mail-filter-update

grep max_size /etc/rspamd/local.d/antivirus.conf

  # If `max_size` is set, messages > n bytes in size are not scanned
  max_size = 20000000;

Updated with testing packages:

rpm -qa|grep nethserver-mail

nethserver-mail-filter-2.30.0-1.2.g354f910.ns7.noarch
nethserver-mail-common-2.30.0-1.2.g354f910.ns7.noarch
nethserver-mail-smarthost-2.30.0-1.2.g354f910.ns7.noarch
nethserver-mail-server-2.30.0-1.2.g354f910.ns7.noarch

~]#  config getprop rspamd VirusScanSize
99999

grep max_size /etc/rspamd/local.d/antivirus.conf

  # If `max_size` is set, messages > n bytes in size are not scanned
  max_size = 99999;

The bug is not reproducible

[nethbot]

in 7.9.2009/updates:

• nethserver-mail-common-2.30.1-1.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-disclaimer-2.30.1-1.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-filter-2.30.1-1.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-getmail-2.30.1-1.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-imapsync-2.30.1-1.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-ipaccess-2.30.1-1.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-p3scan-2.30.1-1.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-quarantine-2.30.1-1.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-server-2.30.1-1.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-mail-smarthost-2.30.1-1.ns7.noarch.rpm x86_64 armhfp aarch64