Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall Object: validate zone name #6537

Closed
stephdl opened this issue Jul 1, 2021 · 4 comments
Closed

Firewall Object: validate zone name #6537

stephdl opened this issue Jul 1, 2021 · 4 comments
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@stephdl
Copy link

stephdl commented Jul 1, 2021

Steps to reproduce

  • In the firewall Object page of cockpit you can create a zone object
  • use some characters in zone name like -
  • save the form and apply your change
  • you have a failed message when shorewall restart

Expected behavior

I expect no errors due to the validation

Actual behavior

With shorewall you have some limitations, 5 maximum length characters, digits, letters and _ are the rule.

Components

nethserver-firewall-base-ui

See also

https://shorewall.org/manpages/shorewall-zones.html

@stephdl stephdl added the bug A defect of the software label Jul 1, 2021
stephdl added a commit to NethServer/nethserver-firewall-base that referenced this issue Jul 1, 2021
Validation of name of zone in the firewall object UI  NethServer/dev#6537
@stephdl stephdl self-assigned this Jul 1, 2021
@stephdl
Copy link
Author

stephdl commented Jul 1, 2021

QA

After installing nethserver-firewall-base and nethserver-firewall-base-ui from testing

Go to create a zone object in the firewall UI, a zone name must start by a letter and contains only digits and letters with _. The maximal length is 5 characters.

@stephdl stephdl added the testing Packages are available from testing repositories label Jul 1, 2021
@nethbot
Copy link
Member

nethbot commented Jul 1, 2021

in 7.9.2009/testing:

@stephdl stephdl removed their assignment Jul 1, 2021
@francio87 francio87 self-assigned this Jul 2, 2021
@francio87
Copy link
Member

Confirm Fixed.

@francio87 francio87 removed their assignment Jul 2, 2021
@francio87 francio87 added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Jul 2, 2021
@nethbot
Copy link
Member

nethbot commented Jul 5, 2021

in 7.9.2009/updates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Development

No branches or pull requests

4 participants