Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collabora 21.11 Update #6607

Closed
mrmarkuz opened this issue Nov 28, 2021 · 18 comments
Closed

Collabora 21.11 Update #6607

mrmarkuz opened this issue Nov 28, 2021 · 18 comments
Assignees
Labels
forge The package belongs to NethForge verified All test cases were verified successfully

Comments

@mrmarkuz
Copy link
Member

New features

With Collabora 21.11 the service loolwsd was renamed to coolwsd and the config tool loolconfig was renamed to coolconfig.

Proposed solution

Add service and config tool name changes to make future updates of Collabora CODE 21.11+ work.

See also

NethServer community


Thanks to Harry_Gleb for raising the issue

@mrmarkuz mrmarkuz self-assigned this Nov 28, 2021
@mrmarkuz mrmarkuz assigned mrmarkuz and unassigned mrmarkuz Nov 28, 2021
@mrmarkuz mrmarkuz added the forge The package belongs to NethForge label Nov 28, 2021
mrmarkuz added a commit to NethServer/nethserver-collabora that referenced this issue Nov 30, 2021
@mrmarkuz mrmarkuz added the testing Packages are available from testing repositories label Nov 30, 2021
@mrmarkuz
Copy link
Member Author

mrmarkuz commented Nov 30, 2021

Install:

yum install nethserver-collabora --enablerepo=nethforge-testing

Update:

yum update nethserver-collabora --enablerepo=nethforge-testing

Test case 1

  • Fresh install
  • Check if documents are editable

Test case 2

  • Update collabora
  • Check if documents are editable
  • The old config db entry loolwsd shouldn't exist anymore

@mrmarkuz mrmarkuz removed their assignment Nov 30, 2021
@stephdl
Copy link

stephdl commented Dec 3, 2021

  • test case 1: install

complete victory the collabora is online

  • test case 2 : upgrade

It fails with an error when I try to edit the document or create another one. I got the error

Dec  3 15:43:44 ns7loc10 coolwsd: wsd-08704-09869 2021-12-03 15:43:44.748806 +0100 [ websrv_poll ] ERR  #21 Exception while processing incoming request: [GET /cool/https:%252F%252Fnextcloud.nethservertest.org%252Findex.php%252Fapps%252Frichdocuments%252Fwopi%252Ffiles%252F484_oc9l15t0n56t%3Faccess_token=Ph2yaE3mXdis3urd3HJ4oyiqC7H9Rlq8&access_token_ttl=0&permission=edit/ws?WOPISrc=https%3A%2F%2Fnextcloud.nethservertest.org%2Findex.php%2Fapps%2Frichdocuments%2Fwopi%2Ffiles%2F484_oc9l15t0n56t&compat=/ws HTTP/1.1#015...]: Invalid or unknown request.| wsd/COOLWSD.cpp:2827

it seems when you restart rh-php73-php-fpm it solves the issue, maybe we can restart php-scl or simply reload ?

@stephdl
Copy link

stephdl commented Dec 3, 2021

a systemctl reload rh-php73-php-fpm is enough

@mrmarkuz we have to handle the case where maybe rh-php73-php-fpm is not installed on the server

@stephdl
Copy link

stephdl commented Dec 6, 2021

can you confirm this behaviour @mrmarkuz ?

@mrmarkuz
Copy link
Member Author

mrmarkuz commented Dec 6, 2021

Yes, it happened in 2 of 3 tests, reloading php-fpm solved it. Maybe it's just some caching issue but hard to find out and maybe browser-specific.

I think we can use

systemctl is-active --quiet rh-php73-php-fpm && systemctl reload rh-php73-php-fpm

in the nethserver-collabora-conf action.

@stephdl
Copy link

stephdl commented Dec 6, 2021

I think about a test like this in an action, yours is shorter than mine :D

What about if the nextcloud and the collabora are remote, it seems there is also an issue, I must admit I did not test it

@mrmarkuz
Copy link
Member Author

mrmarkuz commented Dec 6, 2021

I found it here. I also thought about checking if a file of php73-fpm exists.

Do you think we need a seperate action?

I think the issue with remote collabora was just a missing db entry but I'm going to test it later today and report...and open a pr asap.

@stephdl
Copy link

stephdl commented Dec 6, 2021

Do you think we need a seperate action?

since we need to test if the service exists (else the run-level action could fail) I think we need an action launched at the end, maybe we will remove it in the future

@mrmarkuz
Copy link
Member Author

mrmarkuz commented Dec 6, 2021

I confirm the issue exists with remote collabora too.
In a test with a NethServer Nextcloud VM connecting to a remote NethSever Collabora, I needed to restart php-fpm on the Nextcloud VM after the update of the Collabora VM.
I think we need to add a line to the documentation about remote Collabora.
For a NethServer Nextcloud a signal-event nethserver-nextcloud-update is enough as it restarts rh-php73-php-fpm but for other OS it depends on the PHP configuration.

@stephdl
Copy link

stephdl commented Dec 7, 2021

yes we cannot do something remotely for nown a documentation is probably needed, btw remote installation are maybe not so recurrent

@nethbot
Copy link
Member

nethbot commented Dec 8, 2021

in 7.9.2009/nethforge-testing:

@stephdl stephdl self-assigned this Dec 9, 2021
@stephdl
Copy link

stephdl commented Dec 9, 2021

QA

  • test upgrade with collabora and nextcloud on the same server

success, after the upgrade collabora 21 is up

Dec  9 11:39:14 ns7loc6 esmith::event[22725]: Action: /etc/e-smith/events/actions/adjust-services SUCCESS [0.474049]
Dec  9 11:39:14 ns7loc6 systemd: Reloading The PHP FastCGI Process Manager.
Dec  9 11:39:14 ns7loc6 systemd: Reloaded The PHP FastCGI Process Manager.
Dec  9 11:39:14 ns7loc6 esmith::event[22725]: Action: /etc/e-smith/events/nethserver-collabora-update/S99nethserver-collabora-conf-php SUCCESS [0.064798]
Dec  9 11:39:14 ns7loc6 esmith::event[22725]: Event: nethserver-collabora-update SUCCESS

For the code it is ok now we have to make a documentation note if nextcloud is remote that you might have to reboot the remote host....or does it worth it ?

@stephdl stephdl added the verified All test cases were verified successfully label Dec 9, 2021
@mrmarkuz
Copy link
Member Author

mrmarkuz commented Dec 9, 2021

We need to change from loolwsd to coolwsd in the docs anyway so I'm going to add the line about rebooting remote Nextcloud too.

@gsanchietti gsanchietti removed the testing Packages are available from testing repositories label Dec 9, 2021
mrmarkuz added a commit to NethServer/nethserver-collabora that referenced this issue Dec 9, 2021
@nethbot
Copy link
Member

nethbot commented Dec 9, 2021

in 7.9.2009/nethforge-testing:

mrmarkuz added a commit to NethServer/nethserver-collabora that referenced this issue Dec 10, 2021
@nethbot
Copy link
Member

nethbot commented Dec 10, 2021

in 7.9.2009/nethforge-testing:

@nethbot
Copy link
Member

nethbot commented Dec 11, 2021

in 7.9.2009/nethforge-testing:

@nethbot
Copy link
Member

nethbot commented Dec 11, 2021

in 7.9.2009/nethforge:

@stephdl
Copy link

stephdl commented Dec 11, 2021

released, set closed a big thank you @mrmarkuz

@stephdl stephdl closed this as completed Dec 11, 2021
gsanchietti pushed a commit to NethServer/docs that referenced this issue Dec 13, 2021
In the new version the service name changed from loolwsd to coolwsd and the config tool from loolconf to coolconf.
When using a remote Nextcloud instance, it may need a reboot after Collabora update.
The admin panel URL changed.

NethServer/dev#6607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forge The package belongs to NethForge verified All test cases were verified successfully
Projects
None yet
Development

No branches or pull requests

4 participants