Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vhosts don't honor the trusted networks #6712

Closed
nrauso opened this issue Oct 18, 2022 · 4 comments
Closed

Vhosts don't honor the trusted networks #6712

nrauso opened this issue Oct 18, 2022 · 4 comments
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@nrauso
Copy link

nrauso commented Oct 18, 2022

Vhosts can be configured to allow the access from the trusted networks only:
vhost
but if you modify the trusted networks list, the vhosts configuration is not updated.
This happens because the /etc/httpd/conf.d/virtualhosts.conf file is not expanded by the trusted-networks-modify event.

Workaround:

touch /etc/e-smith/events/trusted-networks-modify/templates2expand/etc/httpd/conf.d/virtualhosts.conf

To fix, we can add the file expansion into the createlinks-virtualhosts, something like:

#--------------------------------------------------
# templates for trusted-networks-modify event
#--------------------------------------------------

$event = 'trusted-networks-modify';

event_templates($event, qw(
             /etc/httpd/conf.d/virtualhosts.conf
));

Steps to reproduce

  • Install nethserver-httpd-virtualhosts package;
  • Create a vhost bounded to trusted networks;
  • Update (add, delete or modify) trusted networks.

Expected behavior

Vhost access should honor the existing trusted networks.

Actual behavior

IPs allowed to access the Vhosts - based upon the trusted networks - are not updated.

Components

  • nethserver-httpd-virtualhosts-3.12.2-1.ns7.noarch
@nethbot
Copy link
Member

nethbot commented Oct 21, 2022

in 7.9.2009/testing:

@gsanchietti
Copy link
Member

Test case

Check the issue is not reproducible

@gsanchietti gsanchietti added the testing Packages are available from testing repositories label Oct 21, 2022
@nrauso nrauso self-assigned this Oct 24, 2022
@nrauso
Copy link
Author

nrauso commented Oct 24, 2022

Test case: verified

@nrauso nrauso removed their assignment Oct 24, 2022
@nrauso nrauso added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Oct 24, 2022
@nethbot
Copy link
Member

nethbot commented Oct 24, 2022

in 7.9.2009/updates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Development

No branches or pull requests

4 participants