Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore asterisk 13 don't restart on update behaviour #6749

Closed
Stell0 opened this issue May 29, 2023 · 5 comments
Closed

Restore asterisk 13 don't restart on update behaviour #6749

Stell0 opened this issue May 29, 2023 · 5 comments
Labels
bug A defect of the software verified All test cases were verified successfully

Comments

@Stell0
Copy link

Stell0 commented May 29, 2023

In Asterisk 13, when package was update, Asterisk wasn't restarted.
This is the safest option, because restart disrupt ongoing calls and on critical services this isn't acceptable

Steps to reproduce

  • update Asterisk 18 package

Expected behavior

Asterisk shouldn't restart itself

Actual behavior

Asterisk restart and active calls hang up
@Stell0 Stell0 added the bug A defect of the software label May 29, 2023
@Stell0 Stell0 mentioned this issue May 29, 2023
Merged
@gsanchietti
Copy link
Member

I'm quite against such change, see PR comments for more info.
I'd prefer the same implementation on Community and Enterprise.

As suggestion, you could:

  • execute a reload of Asterisk instead of a restart
  • implement the reload as "restart when convenient"

Stell0 added a commit to NethServer/asterisk13 that referenced this issue May 30, 2023
@Stell0
Merge pull request #40 from NethServer/6749
f0dacd3 
Don't restart Asterisk on updates NethServer/dev#6749
@nethbot
Copy link
Member

nethbot commented May 30, 2023

in 7.9.2009/testing:

  • asterisk18-addons-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-addons-bluetooth-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-addons-core-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-addons-mysql-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-addons-ooh323-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-ael-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-alembic-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-alsa-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-calendar-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-configs-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-core-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-corosync-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-curl-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-dahdi-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-debuginfo-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-devel-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-doc-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-fax-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-festival-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-hep-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-ldap-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-lua-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-mgcp-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-minivm-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-mwi-external-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-odbc-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-oss-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-pgsql-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-portaudio-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-skinny-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-snmp-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-sqlite3-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-tds-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-unistim-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-voicemail-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-voicemail-odbcstorage-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64
  • asterisk18-voicemail-plain-18.17.1-1.3.gf0dacd3.ns7.x86_64.rpm x86_64

@Stell0
Copy link
Author

Stell0 commented May 30, 2023

when updating package, Asterisk will be restarted because the restart command was in %postun, therefore for testing those packages can be used: version is bigger than the packages in nethserver-testing repository but content is the same
asterisk18-6749.tar.gz

@Stell0 Stell0 added the testing Packages are available from testing repositories label May 30, 2023
@andrea-marchionni
Copy link

Verified.

@Stell0 Stell0 added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Jun 9, 2023
@NethServer NethServer deleted a comment from nethbot Jun 12, 2023
@nethbot
Copy link
Member

nethbot commented Jun 12, 2023

in 7.9.2009/updates:

  • asterisk18-addons-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-addons-bluetooth-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-addons-core-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-addons-mysql-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-addons-ooh323-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-ael-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-alembic-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-alsa-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-calendar-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-configs-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-core-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-corosync-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-curl-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-dahdi-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-debuginfo-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-devel-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-doc-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-fax-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-festival-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-hep-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-ldap-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-lua-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-mgcp-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-minivm-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-mwi-external-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-odbc-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-oss-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-pgsql-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-portaudio-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-skinny-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-snmp-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-sqlite3-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-tds-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-unistim-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-voicemail-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-voicemail-odbcstorage-18.17.1-1.ns7.x86_64.rpm x86_64
  • asterisk18-voicemail-plain-18.17.1-1.ns7.x86_64.rpm x86_64

@Stell0 Stell0 closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect of the software verified All test cases were verified successfully
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gsanchietti @Stell0 @andrea-marchionni @nethbot