Multi-WAN limited to 9 connections

[filippocarletti]

Due to a missing decimal to hexadecimal conversion, the maximum number of wan connections is limited to 9 instead of 15 as documented.

Steps to reproduce

• Create 10 wan connections

Expected behavior

No errors.

Actual behavior

Error:

Checking /etc/shorewall/providers...
   ERROR: Invalid Mark or Mask value (0x100000) /etc/shorewall/providers (line 31)

[nethbot]

in 7.9.2009/testing:

• nethserver-firewall-base-3.19.1-1.2.g68f86a8.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-firewall-base-ui-3.19.1-1.2.g68f86a8.ns7.noarch.rpm x86_64 armhfp aarch64

[gsanchietti]

Test case

Check the issue is not reproducible

[francio87]

Confirm, fixed.

[root@ns79-test ~]# cat /etc/shorewall/providers 

...
...
#
# 80providers_output
#
red1    1       0x10000 -       eth0    10.0.120.1      balance=1,track,persistent
red10   2       0x20000 -       eth0.18 10.1.18.1       balance=1,track,persistent
red11   3       0x30000 -       eth0.19 10.1.19.1       balance=1,track,persistent
red12   4       0x40000 -       eth0.20 10.1.20.1       balance=1,track,persistent
red13   5       0x50000 -       eth0.21 10.1.21.1       balance=1,track,persistent
red14   6       0x60000 -       eth0.22 10.1.22.1       balance=1,track,persistent
red15   7       0x70000 -       eth0.23 10.1.23.1       balance=1,track,persistent
red2    8       0x80000 -       eth0.10 10.1.10.1       balance=1,track,persistent
red3    9       0x90000 -       eth0.17 10.1.17.1       balance=1,track,persistent
red4    10      0xA0000 -       eth0.11 10.1.11.1       balance=1,track,persistent
red5    11      0xB0000 -       eth0.12 10.1.12.1       balance=1,track,persistent
red6    12      0xC0000 -       eth0.13 10.1.13.1       balance=1,track,persistent
red7    13      0xD0000 -       eth0.14 10.1.14.1       balance=1,track,persistent
red8    14      0xE0000 -       eth0.15 10.1.15.1       balance=1,track,persistent
red9    15      0xF0000 -       eth0.16 10.1.16.1       balance=1,track,persistent

[nethbot]

in 7.9.2009/updates:

• nethserver-firewall-base-3.19.2-1.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-firewall-base-ui-3.19.2-1.ns7.noarch.rpm x86_64 armhfp aarch64