Netdata fails to start after update

[nrauso]

After the last updates netdata doesn't start correctly generating this error:

Jun 26 12:50:43 test.nethe.eu systemd[1]: Starting Real time performance monitoring...
Jun 26 12:50:43 test.nethe.eu systemd[1]: Started Real time performance monitoring.
Jun 26 12:50:43 test.nethe.eu netdata[13786]: CONFIG: cannot load cloud config '/var/lib/netdata/cloud.d/cloud.conf'. Running with internal defaults.
Jun 26 12:50:43 test.nethe.eu netdata[13786]: 2023-06-26 12:50:43: netdata INFO  : MAIN : CONFIG: cannot load cloud config '/var/lib/netdata/cloud.d/cloud.conf'. Running wit
Jun 26 12:50:43 test.nethe.eu netdata[13786]: Cannot change directory to '/etc/netdata/conf.d'
Jun 26 12:50:43 test.nethe.eu netdata[13786]: 2023-06-26 12:50:43: netdata FATAL : netdata : Cannot change directory to '/etc/netdata/conf.d' # : No such file or directory
Jun 26 12:50:43 test.nethe.eu netdata[13786]: /usr/sbin/netdata(+0x9f2dc)[0x55f722ebc2dc]
Jun 26 12:50:43 test.nethe.eu netdata[13786]: /usr/sbin/netdata(+0x63d5c)[0x55f722e80d5c]
Jun 26 12:50:43 test.nethe.eu netdata[13786]: /usr/sbin/netdata(+0x66566)[0x55f722e83566]
Jun 26 12:50:43 test.nethe.eu netdata[13786]: /usr/sbin/netdata(+0x5108b)[0x55f722e6e08b]
Jun 26 12:50:43 test.nethe.eu netdata[13786]: /lib64/libc.so.6(__libc_start_main+0xf5)[0x7fc3ea9b8555]
Jun 26 12:50:43 test.nethe.eu netdata[13786]: /usr/sbin/netdata(+0x551d7)[0x55f722e721d7]
Jun 26 12:50:43 test.nethe.eu netdata[13786]: 2023-06-26 12:50:43: netdata INFO  : MAIN : NETDATA SHUTDOWN: initializing shutdown with code 1...

This happens probably because of changes in the plugins paths - from /etc/netdata/conf.d to /usr/lib/netdata/conf.d - introduced by last updates.
We override the content of /etc/netdata/netdata.conf file with a template, forcing the path /etc/netdata/conf.d, we should update it.

Steps to reproduce

• On a fresh installed NethServer, update netdata packages:
  yum -y update \*netdata\*
• Signal the netdata update event:
  signal-event nethserver-netdata-update

Expected behavior

The module should start correctly.

Actual behavior

Module restart keeps failing because of the path /etc/netdata/conf.d does not exist anymore.

Components

netdata-1.39.1-1.el7.x86_64
netdata-conf-1.39.1-1.el7.noarch
netdata-data-1.39.1-1.el7.noarch
nethserver-netdata-2.0.2-1.ns7.noarch

[filippocarletti]

Temporary fix:

sed -i -e '/stock config directory/ s;/etc/netdata/conf.d;/usr/lib/netdata/conf.d;' /etc/netdata/netdata.conf ||:
sed -i -e '/stock health configuration directory/ s;/etc/netdata/conf.d/health.d;/usr/lib/netdata/conf.d/health.d;' /etc/netdata/netdata.conf ||:

[nethbot]

in 7.9.2009/testing:

• nethserver-netdata-2.0.2-1.2.gee11615.ns7.noarch.rpm x86_64 armhfp aarch64

[nrauso]

Tested: verified

[nethbot]

in 7.9.2009/updates:

• nethserver-netdata-2.0.3-1.ns7.noarch.rpm x86_64 armhfp aarch64