docker macvlan documentation #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsanchietti
requested changes
Jun 15, 2020
mrmarkuz
approved these changes
Jun 15, 2020
|
thank @mrmarkuz, I missed it, the prop enableRepository is back |
gsanchietti
reviewed
Jun 17, 2020
administrator-manual/en/docker.rst
Outdated
Comment on lines
139
to
141
|
|
||
| The aeria network is not standard on docker, the developer can be contacted at https://github.com/devplayer0/docker-net-dhcp | ||
|
|
There was a problem hiding this comment.
I'm not still convinced that this should go on the manual. It's an implementation detail, let's move to the README of the package.
Suggested change
| The aeria network is not standard on docker, the developer can be contacted at https://github.com/devplayer0/docker-net-dhcp |
There was a problem hiding this comment.
removed of the official documentation and added to the readme : NethServer/nethserver-docker#19
mrmarkuz
approved these changes
Jun 17, 2020
gsanchietti
approved these changes
Jun 29, 2020
gsanchietti
pushed a commit
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documentation for the macvlan creation