Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic webDAV support for backups + Backup storage stats #9

Merged
merged 54 commits into from Mar 7, 2017

Conversation

dnutan
Copy link
Contributor

@dnutan dnutan commented Feb 13, 2017

@gsanchietti
Copy link
Member

Be patient, I need a little time to review the whole thing :)

@gsanchietti gsanchietti added this to Needs review in NethServer 7 Feb 16, 2017
@gsanchietti gsanchietti self-requested a review February 23, 2017 14:32
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the work!

Testing the pull request i only had one problem: couldn't get to work davfs mount without the server pem linked inside davfs2.conf.

What server did you use to test it?

In the meanwhile, I've rewritten a bit the git history, see https://github.com/gsanchietti/nethserver-backup-data/commits/dnutan-master

@dnutan
Copy link
Contributor Author

dnutan commented Feb 23, 2017

It was tested mainly with a nextcloud server with self-signed certificate, thus I also had to link the certificate to davfs2.conf. But it should work as is with servers that are using valid certificates (AFAIK @robb can confirm that).

At the moment upload of certificates is not supported due to lack of knowledge on nethgui (see http://community.nethserver.org/t/webdav-as-backup-destination/5360). But if requested and with a bit of help from devteam I think I could do it following PKI module as example.

@gsanchietti gsanchietti merged commit ac9617f into NethServer:master Mar 7, 2017
@gsanchietti gsanchietti removed this from Needs review in NethServer 7 Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants