New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic webDAV support for backups + Backup storage stats #9
Conversation
Pending to add URL validator
Pending to add "Advanced" section with buttonList: * to upload remote server certificate * to set client certificate authentication (cert+password)
Pending to create and retrieve db entries for client authentication (cert+password).
each mount point can be specified in its own template fragment
**NOTES** * consider using `df -P -B1` to get bytes as unit (eluding the \*1024 operation on scripts using df output) * consider extra checks on file open
**NOTES** * Consider using [Number::Bytes::Human](http://search.cpan.org/~dagobert/Number-Bytes-Human/Human.pm). Available from EPEL (*perl-Number-Bytes-Human*: Convert byte count to human readable format) * sub `format_bytes` adapted from https://stackoverflow.com/questions/511785/
**NOTES** * Units expressed in KB, MB... for user convenience, but should be KiB, MiB...
Thanks to Rob Bosch
Be patient, I need a little time to review the whole thing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the work!
Testing the pull request i only had one problem: couldn't get to work davfs mount without the server pem linked inside davfs2.conf.
What server did you use to test it?
In the meanwhile, I've rewritten a bit the git history, see https://github.com/gsanchietti/nethserver-backup-data/commits/dnutan-master
It was tested mainly with a nextcloud server with self-signed certificate, thus I also had to link the certificate to davfs2.conf. But it should work as is with servers that are using valid certificates (AFAIK @robb can confirm that). At the moment upload of certificates is not supported due to lack of knowledge on nethgui (see http://community.nethserver.org/t/webdav-as-backup-destination/5360). But if requested and with a bit of help from devteam I think I could do it following PKI module as example. |
NethServer/dev#5235