Networks page: Properly show hotspot interface

[andre8244]

• Display hotspot interface with a proper icon and a distinctive color
• Show tun-dedalo CIDR address

NethServer/dev#6186

[nethbot]

in 7.8.2003/autobuild:

• nethserver-cockpit-1.7.1-1.10.pr269.geb846af.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-cockpit-lib-1.7.1-1.10.pr269.geb846af.ns7.noarch.rpm x86_64 armhfp aarch64

[gsanchietti]

I have mixed feelings on this one.
While the patch for sure reaches the goal, you're hard-coding stuff from an extra package (nethserver-dedalo, not widely used) straight into the core.

IMO this is not acceptable from an architecture point of view

[andre8244]

I have mixed feelings on this one.
While the patch for sure reaches the goal, you're hard-coding stuff from an extra package (nethserver-dedalo, not widely used) straight into the core.

IMO this is not acceptable from an architecture point of view

You are right, I didn't think about this architectural aspect. Is your concern about the tun-dedalo CIDR retrieval only, or to the hotspot role management as a whole? Not showing hotspot CIDR could be a good compromise?

[gsanchietti]

You are right, I didn't think about this architectural aspect. Is your concern about the tun-dedalo CIDR retrieval only, or to the hotspot role management as a whole? Not showing hotspot CIDR could be a good compromise?

The hotspot role as a whole, I didn't never liked it. Still, it's there since NethServer 6 and the role didn't change the name so I think it's stable enough.
Let's go with displaying just not displaying the CIDR, so you do not need to hard-code tun-dedalo interface name ;)

[nethbot]

in 7.8.2003/autobuild:

• nethserver-cockpit-1.7.1-1.11.pr269.g5c92503.ns7.noarch.rpm x86_64 armhfp aarch64
• nethserver-cockpit-lib-1.7.1-1.11.pr269.g5c92503.ns7.noarch.rpm x86_64 armhfp aarch64