Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release all IP in shorewal dynamic #76

Merged
merged 1 commit into from Nov 27, 2019

Conversation

stephdl
Copy link
Collaborator

@stephdl stephdl commented Nov 25, 2019

With the move ipset for fail2ban, it possibly have some IP still banned in the dynamic zone of shorewall, we can release them safely, when fail2ban will restart, the logs will be inspected again and the relevant IP will be banned in ipset

NethServer/dev#5943

@nethbot
Copy link
Member

nethbot commented Nov 25, 2019

in 7.7.1908/autobuild:

Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action should be called once after the upgrade.
This implementation wipes the dynamic chain at every fail2ban update preventing the use of shorewall block command.

@gsanchietti
Copy link
Member

gsanchietti commented Nov 26, 2019

The /var/lib/nethserver/fail2ban/fail2ban.json file could be used as a flag: if it contains the IPList (or IPDebug) field, we are doing an upgrade.
The field will be removed on next fail2ban-statistics run: https://github.com/NethServer/nethserver-fail2ban/blob/master/root/usr/libexec/nethserver/fail2ban-statistics#L79

@nethbot
Copy link
Member

nethbot commented Nov 27, 2019

in 7.7.1908/autobuild:

Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use grep instead of bash matching operator, but it's ok :)

@gsanchietti gsanchietti merged commit e0eab18 into NethServer:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants