Restart speedtest each time needed #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
force-pushed
the
speedTest
branch
2 times, most recently
from
0e1b024
to
8e9c2f4
Compare
gsanchietti
requested changes
Jan 7, 2021
There was a problem hiding this comment.
In my opinion, both "Server sponsor" and "Server ID" doesn't really offer a real value to the normal user.
What is the user supposed to do with them? The user should now the command line cli syntax to have relevant information from it.
If we want to expose extra info, it should be hidden by default.
|
We are in a popover, we cannot display much informations and it is a pity because with the last version of speedtest-cli we could display the ISP, the external public IP, much informations. However I came to the conclusion that it could be a good new network tool, let's remove it for now |
|
speedtest-cli updated and available in nethserver-testing |
gsanchietti
approved these changes
Jan 7, 2021
edospadoni
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR intends to fix
/sto the value of download/uploadNethServer/dev#6385