Migration tool fixes and enhancements #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a different interface name, ns8, to avoid naming confilicts with existing Wireguard setups.
Rename the DB record, once, if it's found in configuration DB.
The agent is useless in ns7, only API client requests are needed.
DavidePrincipi
force-pushed
the
fix-wg
branch
from
4f5355c
to
054aac5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
The API must return the full error if response payload has some issue.
This comment was marked as outdated.
This comment was marked as outdated.
- Remove the node if already present - Remove the external LDAP domain, if already present
DavidePrincipi
force-pushed
the
fix-wg
branch
from
0fee911
to
ebf16e3
Compare
|
in
|
gsanchietti
reviewed
Nov 29, 2023
| $oldRecord->delete(); | ||
| system('systemctl', 'disable', '--now', 'wg-quick@wg0'); | ||
| rename('/etc/wireguard/wg0.conf', '/etc/wireguard/ns8.conf'); | ||
| system('systemctl', 'enable', '--now', 'wg-quick@ns8'); |
There was a problem hiding this comment.
This should not be needed: let's the system handle it
andre8244
reviewed
Nov 29, 2023
Co-authored-by: Andrea Leardini <andrea.leardini@nethesis.it>
Co-authored-by: Giacomo Sanchietti <giacomo.sanchietti@nethesis.it>
|
in
|
andre8244
approved these changes
Nov 30, 2023
|
in
|
|
in
|
|
in
|
gsanchietti
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs
Additionally: