Fix SSH login failure with conflicting group permissions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
changed the title
DavidePrincipi
changed the title
root/etc/e-smith/templates/etc/ssh/sshd_config/70Restricted2Sftp
Outdated
Show resolved
Hide resolved
root/etc/e-smith/templates/etc/ssh/sshd_config/70Restricted2Sftp
Outdated
Show resolved
Hide resolved
root/etc/e-smith/templates/etc/ssh/sshd_config/70Restricted2Sftp
Outdated
Show resolved
Hide resolved
DavidePrincipi
approved these changes
Feb 12, 2020
|
This patch seems to fix the bug, however wait a moment to merge it. We must be sure it can work with the planned enhancement NethServer/dev#6059 |
There was a problem hiding this comment.
Summary: I bet we don't need to record the groups with SFTP only access. On the contrary, we are interested in the list of those who can access SSH. Anyone else can do SFTP, provided login permission is granted.
This is the logic of the MatchGroup/MatchAll directives: we can take advantage of it!
root/etc/e-smith/templates/etc/ssh/sshd_config/45AllowGroups2Sshd
Outdated
Show resolved
Hide resolved
root/etc/e-smith/templates/etc/ssh/sshd_config/45AllowGroups2Sshd
Outdated
Show resolved
Hide resolved
root/etc/e-smith/templates/etc/ssh/sshd_config/45AllowGroups2Sshd
Outdated
Show resolved
Hide resolved
root/etc/e-smith/templates/etc/ssh/sshd_config/70Restricted2Sftp
Outdated
Show resolved
Hide resolved
root/etc/e-smith/templates/etc/ssh/sshd_config/70Restricted2Sftp
Outdated
Show resolved
Hide resolved
root/etc/e-smith/templates/etc/ssh/sshd_config/70Restricted2Sftp
Outdated
Show resolved
Hide resolved
root/etc/e-smith/templates/etc/ssh/sshd_config/70Restricted2Sftp
Outdated
Show resolved
Hide resolved
root/etc/e-smith/templates/etc/ssh/sshd_config/45AllowGroups2Sshd
Outdated
Show resolved
Hide resolved
root/etc/e-smith/templates/etc/ssh/sshd_config/70Restricted2Sftp
Outdated
Show resolved
Hide resolved
DavidePrincipi
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NethServer/dev#6058
NethServer/dev#6059