Use authentication without TLS #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in |
7 tasks
gsanchietti
reviewed
Dec 19, 2018
There was a problem hiding this comment.
Could this change cause problems on current installation?
Should we change the config only if IdentityPolicy is enabled or can we safely always enable the authentication?
IMO, authentication should be always safe but some checks are needed (also for root user)
|
since we use a regex, root@domain.com (used by roundcubemail to send from root) is matched tested it is good for me |
gsanchietti
approved these changes
Dec 19, 2018
DavidePrincipi
requested changes
Dec 19, 2018
DavidePrincipi
approved these changes
Jan 7, 2019
DavidePrincipi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NethServer/dev#5672
Force to use smtp authentication even on localhost