Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the JWT join token in audit trail #648

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

DavidePrincipi
Copy link
Member

@DavidePrincipi DavidePrincipi commented Jun 21, 2024

The JWT join token is a sensible value: we must obfuscate it before writing the audit trail.

E.g. in join-cluster

{
  "action": "join-cluster",
  "data": {
    "jwt": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVAJ9.eyIyZmEiOmZhbHNlLCJhY3Rpb25zIjpbXSwiZXhwIjoxNzE5NTUyNDk0LCJpZCI6ImFkbWluIiwib3JpZ19pYXQiOjE3MTgzNDI4OTQtInJvbGUiOiIifQ.b8CC4HZOSoiu_rtZ7gRw6fXqBa-2GuixLT0oTP7vhnc",
    "tls_verify": true,
    "url": "https://rl1.dp.nethserver.net"
  },
  "extra": {
    "isNotificationHidden": true,
    "title": "Join a cluster",
    "toastTimeout": 0
  },
  "id": "f1f315a7-9721-4570-ac01-9ebc4e47f786",
  "parent": "",
  "queue": "cluster/tasks",
  "timestamp": "2024-06-20T13:23:37.028891077Z",
  "user": "admin"
}

The JWT join token is a sensible value: we must obfuscate it before writing the
audit trail.
@DavidePrincipi DavidePrincipi changed the title Hide the JWT join token in audit trail. Hide the JWT join token in audit trail Jun 24, 2024
@DavidePrincipi DavidePrincipi merged commit 331b1bb into main Jun 24, 2024
2 checks passed
@DavidePrincipi DavidePrincipi deleted the audit-hide-jwt branch June 24, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants