Upload custom certificate

[Tbaile]

Added action allowing upload of custom certificate to Traefik

Trello Ref

[Amygos]

Are you planning to add also the implementation for the list, get, and delete actions?

[Tbaile]

There are already implementations for delete, list and get of certificates (they're there, no idea if they actually work or they were placed only to be implemented after). None less they are based off Traefik internal API, that doesn't show at all certificates information. I've highlighted the issue in this card and the related UI implementation NethServer/ns8-core#407.

[Amygos]

There are already implementations for delete, list and get of certificates (they're there, no idea if they actually work or they were placed only to be implemented after)

The current actions are fully implemented and working but don't deal with custom certificates.

None less they are based off Traefik internal API, that doesn't show at all certificates information. I've highlighted the issue in this card and the related UI implementation NethServer/ns8-core#407.

There is no issue, it is an implementation choice.
Traefik doesn't allow explicit requests and management of a certificate, but only implicit via the expression in the rule section of a route definition. Due to this limitation as a workaround, we create a route with the name in the format certificate-<domain_name> and then we set the route's rule expression as:

Host(`<domain_name>`) && Path(`<random_path>`)`

In this way, traefik will try to request the certificate for the domain via the acme server. You can see the implementation here
The same logic is applied to the del, get, list actions.

[Tbaile]

That makes way more sense now.
So, the only thing that remains is to load the certificate as a route in the Redis configuration, this allows to use again all the implementation already present. Are there any issues with this approach?

[Amygos]

So, the only thing that remains is to load the certificate as a route in the Redis configuration,

I don't think this is the correct way to implement it, you have to change a lot of code anyway and you have also to deal with the files on disk.
At this point is better to read the certificates list from the disk and add a new field to the output of the get-certificate action, e.g. type:"[ internal | custom ]"

[Tbaile]

I'll split the management of custom certificates in a separate PR, feel free to merge this when you like.