Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blake2sFinalize #280

Closed
Tracked by #164
cicr99 opened this issue Mar 13, 2024 · 2 comments · Fixed by #375
Closed
Tracked by #164

Blake2sFinalize #280

cicr99 opened this issue Mar 13, 2024 · 2 comments · Fixed by #375
Assignees
@TropicalDog17
Labels
cairo zero Exclusively targets cairo zero Difficulty: intermediate Requires some skill but you will get help Duration: few days Will take a few days and might need feedback from several people ODHack Good issues to tackle during ODHack 3.0 vm hint Related with VM hints

Comments

@cicr99
Copy link
Contributor

cicr99 commented Mar 13, 2024 •
edited
Loading

Finalizes the BLAKE2s hashing process. It involves asserting the packed instances and input chunk size, preparing a dummy message, computing the hash with modified initialization vectors, and adding padding to align with the number of packed instances.

Reference: https://github.com/starkware-libs/cairo-lang/blob/efa9648f57568aad8f8a13fbf027d2de7c63c2c0/src/starkware/cairo/common/cairo_blake2s/blake2s.cairo#L184

This hint needs to implement blake2s_compress method which is also used in #279, so whichever is solved first will make the other one easier
@cicr99 cicr99 mentioned this issue Mar 13, 2024
Closed
@cicr99 cicr99 changed the title Blake2sFinalize: Finalizes the BLAKE2s hashing process. It involves asserting the packed instances and input chunk size, preparing a dummy message, computing the hash with modified initialization vectors, and adding padding to align with the number of packed instances. Blake2sFinalize Mar 13, 2024
@cicr99 cicr99 added vm hint Related with VM hints cairo zero Exclusively targets cairo zero Difficulty: intermediate Requires some skill but you will get help Duration: few days Will take a few days and might need feedback from several people labels Mar 13, 2024
@rodrigo-pino rodrigo-pino added the ODHack Good issues to tackle during ODHack 3.0 label Apr 23, 2024
@TropicalDog17
Copy link
Contributor

@rodrigo-pino @cicr99 Hi, could I work on this issue?

@cicr99
Copy link
Contributor Author

cicr99 commented Apr 24, 2024

Sure @TropicalDog17 !
Make sure to check #164 description which contains some resources that might be useful for this task.

@TropicalDog17 TropicalDog17 mentioned this issue Apr 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TropicalDog17 TropicalDog17

Labels
cairo zero Exclusively targets cairo zero Difficulty: intermediate Requires some skill but you will get help Duration: few days Will take a few days and might need feedback from several people ODHack Good issues to tackle during ODHack 3.0 vm hint Related with VM hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: blake2s finalize TropicalDog17/cairo-vm-go
3 participants
@cicr99 @rodrigo-pino @TropicalDog17