Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Integration Tests for Cairo Zero Hints #413

Closed
91 tasks done
TAdev0 opened this issue May 16, 2024 · 3 comments
Closed
91 tasks done

Implement Integration Tests for Cairo Zero Hints #413

TAdev0 opened this issue May 16, 2024 · 3 comments
Assignees
@har777 @cicr99 @MaksymMalicki @Sh0g0-1758 @TAdev0
Labels
cairo zero Exclusively targets cairo zero enhancement New feature or request tests vm hint Related with VM hints

Comments

@TAdev0
Copy link
Member

TAdev0 commented May 16, 2024 •
edited
Loading

Cairo Zero hints are currently being implemented. This issue summarises the state of integration tests for Cairo Zero hints.

Some hints are inter-related, and should be tested together. For example, the process of dictionaries squashing involves many hints, while integration test should ensure squashing process works properly after all hints are implemented. Same for usort where the action of sorting a list requires all usort-related hint.

Uint256 Operations

  • Uint256Add
  • Split64
  • Uint256SignedNN
  • Uint256UnsignedDivRem
  • Uint256MulDivMod
  • Uint256Sqrt

Math Operations

  • IsNn
  • IsNnOutOfRange
  • IsLeFelt
  • AssertLtFelt
  • Pow
  • IsPositive
  • SplitFelt
  • SplitInt
  • SplitIntAssertRange
  • AssertNotZero
  • AssertNn
  • AssertNotEqual
  • Assert250Bits
  • AssertLeFelt
  • AssertLeFeltExcluded0
  • AssertLeFeltExcluded1
  • AssertLeFeltExcluded2
  • Sqrt
  • UnsignedDivRem
  • SignedDivRem
  • IsQuadResidue

Usort

  • UsortEnterScope
  • UsortBody
  • UsortVerify
  • UsortVerifyMultiplicityAssert
  • UsortVerifyMultiplicityBody

Elliptic Curve Operations

  • EcNegate
  • EcDoubleSlopeV1
  • ComputeSlopeV1
  • EcDoubleAssignNewXV1
  • EcDoubleAssignNewYV1
  • NondetBigint3V1
  • FastEcAddAssignNewX
  • FastEcAddAssignNewY
  • isZeroNondet
  • ReduceV1
  • isZeroDivMod
  • EcMulInner
  • RandomEcPoint (ecop builtin hint)
  • ChainedEcopRandomEcPoint (ecop builtin hint)

Signatures (ECDSA & SEC_P)

  • VerifyEcdsaSignature
  • ImportSecp256R1P
  • VerifyZero
  • DivModNPackedDivmodV1
  • DivModNSafeDiv
  • GetPointFromX

Blake Hash

  • Blake2sCompute
  • Blake2sAddUint256
  • Blake2sAddUint256Bigend
  • Blake2sFinalize

Keccak

  • UnsafeKeccak
  • UnsafeKeccakFinalize
  • BlockPermutation
  • CairoKeccakFinalize
  • KeccakWriteArgs
  • keccak builtin hints

Dictionaries

  • DefaultDictNew
  • DictRead
  • DictWrite
  • DictUpdate
  • SquashDict
  • SquashDictInnerSkipLoop
  • SquashDictInnerFirstIteration
  • SquashDictInnerCheckAccessIndex
  • SquashDictInnerContinueLoop
  • SquashDictInnerAssertLenKeys
  • SquashDictInnerLenAssert
  • SquashDictInnerUsedAccessesAssert
  • SquashDictInnerNextKey
  • DictSquashCopyDict
  • DictSquashUpdatePtr
  • DictNew

Other

  • AllocSegment
  • SetAdd
  • VmExitScope
  • VmEnterScope
  • MemcpyEnterScope
  • MemcpyContinueCopying
  • MemsetEnterScope
  • MemsetContinueLoop
  • FindElement
  • SearchSortedLower
  • AllocSegment
  • NondetElementsOverTWo (poseidon builtin)
  • NondetElementsOverTen (poseidon builtin)
@TAdev0 TAdev0 added enhancement New feature or request tests vm hint Related with VM hints cairo zero Exclusively targets cairo zero labels May 16, 2024
@Osatuyi
Copy link

Osatuyi commented May 21, 2024

Hello @TAdev0 I will like to be assigned this.

@TAdev0
Copy link
Member Author

TAdev0 commented May 21, 2024

Hi ,
This is not an issue that can be grabbed, but more of a reminder for us

@Osatuyi
Copy link

Osatuyi commented May 21, 2024

oh okay

@TAdev0 TAdev0 added the blocked Depends on another to be solved first label May 22, 2024
@Sh0g0-1758 Sh0g0-1758 mentioned this issue Jun 6, 2024
Closed
7 tasks
@har777 har777 mentioned this issue Jun 7, 2024
Merged
This was referenced Jun 12, 2024
Closed
Merged
Merged
@TAdev0 TAdev0 mentioned this issue Jun 22, 2024
Closed
@TAdev0 TAdev0 removed the blocked Depends on another to be solved first label Jun 25, 2024
@TAdev0 TAdev0 closed this as completed Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@har777 har777

@cicr99 cicr99

@MaksymMalicki MaksymMalicki

@Sh0g0-1758 Sh0g0-1758

@TAdev0 TAdev0

Labels
cairo zero Exclusively targets cairo zero enhancement New feature or request tests vm hint Related with VM hints
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@har777 @cicr99 @MaksymMalicki @Osatuyi @Sh0g0-1758 @TAdev0