Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullables #63

Open
flcl42 opened this issue Dec 12, 2023 · 1 comment
Open

Fix nullables #63

flcl42 opened this issue Dec 12, 2023 · 1 comment
Labels
good first issue Good for newcomers refactoring
Milestone
alpha

Comments

@flcl42
Copy link
Contributor

flcl42 commented Dec 12, 2023

Description
A lot of nullable warnings in several modules

Steps to Reproduce
cd src/libp2p && dotnet build

Expected behavior
Nullable variables are checked for nulls properly
@flcl42 flcl42 added good first issue Good for newcomers refactoring labels Dec 12, 2023
@flcl42 flcl42 mentioned this issue Dec 12, 2023
Merged
@flcl42 flcl42 added this to the alpha milestone Dec 14, 2023
@shubham-sonthalia
Copy link

shubham-sonthalia commented Feb 23, 2024 •
edited
Loading

HI @flcl42 , have created this PR for resolving the issue - #74

All warnings are resolved now. Kindly review.

Screenshot 2024-02-23 at 11 04 28 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactoring
Projects
None yet
Milestone
alpha
Development

No branches or pull requests
2 participants
@flcl42 @shubham-sonthalia