Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

update deployment instruction in docs #659

Merged
merged 2 commits into from Sep 8, 2022

Conversation

jelilat
Copy link
Contributor

@jelilat jelilat commented Aug 19, 2022

The current deployment instruction warp deploy <path to Cairo contract> returns an error when you call it. I updated it with the right deployment command.

@jelilat jelilat marked this pull request as ready for review August 19, 2022 09:19
Copy link
Contributor

@BitBaseBit BitBaseBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit to alert the user in the CLI that we have used those parameters. And then put it in the docs somewhere.

@jelilat
Copy link
Contributor Author

jelilat commented Aug 19, 2022

I'm not sure I understand your comment @BitBaseBit

@JorikSchellekens
Copy link
Contributor

@jelilat you can create a "user" on StarkNet, check warp deploy-account which deploys a user and creates a file tracking them in your home directory. If there is a __default__ user in this file it will be used by warp and --no-wallet is no longer required. Can you update the readme to include the account deployment steps instead of no-wallet? Also the gateway can be set in an env - would be nice to have that in the readme too.

Thank you for catching this!

@JorikSchellekens
Copy link
Contributor

I've updated the readme accordingly. Thanks for the initial pr @jelilat

Copy link
Contributor

@JorikSchellekens JorikSchellekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to be cheeky and approve this for myself :D

@jelilat
Copy link
Contributor Author

jelilat commented Sep 8, 2022

Thanks @JorikSchellekens

Sorry I wasn't able to get to this sooner.

@swapnilraj swapnilraj merged commit 2da8f52 into develop Sep 8, 2022
@swapnilraj swapnilraj deleted the jelilat/update_deployment_instruction branch September 8, 2022 09:52
@JorikSchellekens
Copy link
Contributor

Ah np, just appreciate the input!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants