Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the commit to alert the user in the CLI that we have used those parameters. And then put it in the docs somewhere.
I'm not sure I understand your comment @BitBaseBit |
@jelilat you can create a "user" on StarkNet, check Thank you for catching this! |
I've updated the readme accordingly. Thanks for the initial pr @jelilat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to be cheeky and approve this for myself :D
Thanks @JorikSchellekens Sorry I wasn't able to get to this sooner. |
Ah np, just appreciate the input! |
The current deployment instruction
warp deploy <path to Cairo contract>
returns an error when you call it. I updated it with the right deployment command.