Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tier tagger only showing vanilla tiers. #13

Closed
pqvo13 opened this issue Dec 24, 2023 · 9 comments
Closed

Tier tagger only showing vanilla tiers. #13

pqvo13 opened this issue Dec 24, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@pqvo13
Copy link

pqvo13 commented Dec 24, 2023

Vanilla tiers only thing that actually works, even if you swap to like nethpot and make sure the player is tested in nethpot nothing pops up.

@uku3lig
Copy link
Collaborator

uku3lig commented Dec 24, 2023

thanks for the report! could you please provide me with your minecraft version, the version of tiertagger you are using and if possible a logfile?

@pqvo13
Copy link
Author

pqvo13 commented Dec 25, 2023 via email

@pqvo13
Copy link
Author

pqvo13 commented Dec 26, 2023

Sorry but im wondering has it been resolved or is it still in progress?

@uku3lig
Copy link
Collaborator

uku3lig commented Dec 27, 2023

okay, i can reproduce the issue. it seems like something changed in the mctiers api that broke every gamemode except vanilla.

fun.

@uku3lig uku3lig added the bug Something isn't working label Dec 27, 2023
@uku3lig uku3lig self-assigned this Dec 27, 2023
@uku3lig
Copy link
Collaborator

uku3lig commented Dec 27, 2023

it seems that doing ?count=32767 to get the whole tier list doesn't work anymore (except on vanilla for some unknown reason?)

@QuadraticKid was anything changed for this to be broken?

@pqvo13
Copy link
Author

pqvo13 commented Dec 28, 2023

just let me know if you guys fix it, thanks!

@uku3lig
Copy link
Collaborator

uku3lig commented Dec 28, 2023

upon further investigation, it seems that vanilla for some unknown reason works fine with count=32767, but other modes (tested only on neth_pot) only accept a count corresponding to the amount of people in the list (in this case, 1068). surprisingly, doing something like from=1050&count=25 (anologous to what the website would do) still returns a 503 ...

@QuadraticKid
Copy link

QuadraticKid commented Dec 29, 2023

Requesting 32 thousand users from an endpoint is EXTREMELY abusive, and the 503 errors are caused by server overload due to you guys.
You have to remember that every person who installs your mod will make a request like that under the conditions you specify.
I have limited the api/tier endpoint to 50 players per query, spamming this endpoint will result in further restrictions to the API.

Please consider using something that loads on the fly, such as requesting a tier of a user with /api/rankings/<uuid> when they come into render distance. Please also cache this locally for at lease some duration as to not spam the server.

@xyzeva
Copy link

xyzeva commented Dec 29, 2023

Requesting 32 thousand users from an endpoint is EXTREMELY abusive, and the 503 errors are caused by server overload due to you guys. You have to remember that every person who installs your mod will make a request like that under the conditions you specify. I have limited the api/tier endpoint to 50 players per query, spamming this endpoint will result in further restrictions to the API.

Please consider using something that loads on the fly, such as requesting a tier of a user with /api/rankings/ when they come into render distance. Please also cache this locally for at lease some duration as to not spam the server.

maybe you should use caching instead of doing direct database queries on every request :)

also, this mod only requests it once on startup, so it does cache it, you should cache it too.

uku3lig added a commit that referenced this issue Dec 30, 2023
uku3lig added a commit that referenced this issue Dec 31, 2023
uku3lig added a commit that referenced this issue Jan 1, 2024
uku3lig added a commit that referenced this issue Jan 1, 2024
uku3lig added a commit that referenced this issue Jan 1, 2024
uku3lig added a commit that referenced this issue Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants