Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lib version #9

Closed
deckameron opened this issue Feb 1, 2019 · 11 comments
Closed

Update lib version #9

deckameron opened this issue Feb 1, 2019 · 11 comments

Comments

@deckameron
Copy link

deckameron commented Feb 1, 2019

Hi @drauggres,

I was looking for way to use 360 videos (surface_type : "spherical_view") and noticed that it is only possible in version 2.9.0. It is now in 2.9.4.

Could you please update it to a newer version? :-)
Thank you!

@drauggres
Copy link
Collaborator

Hi @deckameron.

I have tried to update to 2.9.0 in november, and was able to build module with it, but I couldn't get it work with Titanium because of Java 8:

Turn on Java 8 compiler support for the ExoPlayer library. Apps may need to add compileOptions { targetCompatibility JavaVersion.VERSION_1_8 } to their gradle settings to ensure bytecode compatibility.

Ticket in Appcelerators JIRA.

@drauggres
Copy link
Collaborator

drauggres commented Feb 4, 2019

If you want to try it yourself:
https://github.com/NetrisTV/ti.exoplayer/tree/test-2.9.1

git fetch origin
git checkout -b test-2.9.1 origin/test-2.9.1
cd android
ti clean
rm lib/*.aar lib/*.jar
cd ..
./gradlew app:tiBuild

@deckameron
Copy link
Author

deckameron commented Feb 4, 2019

Thank you @drauggres ! I will give it a try.

[EDIT]
Just tried to build it and got the following error:

[ERROR] Failed to compile Java source files:
[ERROR] build
[ERROR] Likely fix is to remove from proxy.propertyAccessors listing, as both getter and setter methods are defined.
 
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:tiBuild'.
> Process 'command 'ti'' finished with non-zero exit value 1

It has something to do with this part of VideoPlayerProxy.java

// clang-format off
@Kroll.proxy(creatableInModule = TiExoplayerModule.class, propertyAccessors = {
		TiC.PROPERTY_AUTOPLAY,
		TiC.PROPERTY_DURATION,
		TiC.PROPERTY_END_PLAYBACK_TIME,
		TiC.PROPERTY_INITIAL_PLAYBACK_TIME,
		TiC.PROPERTY_PLAYABLE_DURATION,
		TiC.PROPERTY_REPEAT_MODE,
		TiC.PROPERTY_URL,
		TiExoplayerModule.PROPERTY_CONTENT_EXTENSION,
		TiExoplayerModule.PROPERTY_CONTENT_TYPE,
		TiExoplayerModule.PROPERTY_DRM_KEY_REQUEST_PROPERTIES,
		TiExoplayerModule.PROPERTY_DRM_LICENSE_URL,
		TiExoplayerModule.PROPERTY_DRM_MULTI_SESSION_EXTRA,
		TiExoplayerModule.PROPERTY_DRM_SCHEME_UUID_EXTRA,
		TiExoplayerModule.PROPERTY_PREFER_EXTENSION_DECODERS,
		TiExoplayerModule.PROPERTY_LINEAR_GAIN,
		TiExoplayerModule.PROPERTY_SURFACE_TYPE
})

Do you have any ideia how to solve it?

@drauggres
Copy link
Collaborator

Sorry, I'm still on 7.4.1.
Fix for 7.5.0 to the same branch.

BTW, It would be better if you just add new comments instead of editing (if this is not a typo or something like that). Github doesn't send notifications when comments are modified, only for new ones.

@drauggres
Copy link
Collaborator

drauggres commented Mar 18, 2019

https://jira.appcelerator.org/browse/TIMOB-26919

@drauggres
Copy link
Collaborator

tidev/node-titanium-sdk#80
tidev/titanium-sdk#10809

drauggres added a commit that referenced this issue Mar 27, 2019
@drauggres
Copy link
Collaborator

@deckameron
You can try to build module from test-2.9.6 branch.

const ExoPlayer = require("ru.netris.mobile.exoplayer");
const videoPlayer = ti_exoplayer.createVideoPlayer({
  ...
  surfaceType: ExoPlayer.SURFACE_TYPE_SPHERICAL_VIEW
});

If you don't have playservices in your app then comment out extension-ima in app/build.gradle or just delete extension-ima-*.aar from lib directory after module unpacking.

@deckameron
Copy link
Author

Hi @drauggres
I tried building the module but I got this error:

[ERROR] /Users/sandrobarnabe/Documents/Modules/ti.exoplayer-test-2.9.6/android/build/intermediates/res/merged/layout/player_view_none.xml:2: error: No resource identifier found for attribute 'surface_type' in package 'ru.netris.mobile.exoplayer'

/Users/sandrobarnabe/Documents/Modules/ti.exoplayer-test-2.9.6/android/build/intermediates/res/merged/layout/player_view_spherical_view.xml:2: error: No resource identifier found for attribute 'surface_type' in package 'ru.netris.mobile.exoplayer'

/Users/sandrobarnabe/Documents/Modules/ti.exoplayer-test-2.9.6/android/build/intermediates/res/merged/layout/player_view_surface_view.xml:2: error: No resource identifier found for attribute 'surface_type' in package 'ru.netris.mobile.exoplayer'

/Users/sandrobarnabe/Documents/Modules/ti.exoplayer-test-2.9.6/android/build/intermediates/res/merged/layout/player_view_texture_view.xml:2: error: No resource identifier found for attribute 'surface_type' in package 'ru.netris.mobile.exoplayer'


[ERROR] Failed to generate R class

@drauggres
Copy link
Collaborator

Strange, just built it on different machine.
https://github.com/NetrisTV/ti.exoplayer/releases/tag/2.2.0-alpha

@drauggres
Copy link
Collaborator

drauggres added a commit that referenced this issue Feb 28, 2020
@drauggres
Copy link
Collaborator

Version 3.0.0 released with ExoPlayer v2.9.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants