move name validation to route deserialization #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplified name types implementation of validate. added new trait functions. I wouldn't say its better, just different
refac Names to original/ update project/groups/roles to use name deserial validation
brollb
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Thanks, @samankittani ! Nice work.
I added one comment about how we should be able to simplify the implementation of the different name validation. Otherwise, looks good!
| } | ||
|
|
||
| #[derive(Clone, Debug, PartialEq, Eq, TS)] | ||
| pub struct Name<T: Validate>(String, std::marker::PhantomData<T>); |
There was a problem hiding this comment.
Why are we re-using this struct for all the different types of names rather than creating completely different versions for each (ie, struct GroupName rather than type GroupName = ..)? Is it just for code re-use?
If so, I am concerned that this approach introduces complexity that doesn't buy us much. For example, we could impl Validate for each of the GroupName, etc, structs (as opposed to type aliases) then define a blanket implementation for all structs that implement Validate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr moves name validation to serde deserialization step