Skip to content

Commit

Permalink
linux: modern kernels can create stable private addresses
Browse files Browse the repository at this point in the history
Just improve the comment.
Closes #301
  • Loading branch information
rsmarples committed Apr 8, 2024
1 parent faa3f54 commit 9d2e7e7
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions src/if-linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -2154,17 +2154,16 @@ if_setup_inet6(const struct interface *ifp)
int ra;
char path[256];

/* The kernel cannot make stable private addresses.
/* Modern linux kernels can make a stable private address.
* However, a lot of distros ship newer kernel headers than
* the kernel itself so sweep that error under the table. */
* the kernel itself so we sweep that error under the table
* from old kernels and just make them ourself regardless. */
if (if_disable_autolinklocal(ctx, ifp->index) == -1 &&
errno != ENODEV && errno != ENOTSUP && errno != EINVAL)
logdebug("%s: if_disable_autolinklocal", ifp->name);

/*
* If not doing autoconf, don't disable the kernel from doing it.
* If we need to, we should have another option actively disable it.
*/
/* If not doing autoconf, don't disable the kernel from doing it.
* If we need to, we should have another option actively disable it. */
if (!(ifp->options->options & DHCPCD_IPV6RS))
return;

Expand Down

1 comment on commit 9d2e7e7

@perkelix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot help but wonder what is the point of disregarding the stable private addresses generated by the kernel itself.

Please sign in to comment.