hooks/30-hostname: Exit with 0 if setting hostname is not needed #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the hostname is already set before dhcpcd is started, `need_hostname` will hit the "No old hostname" case and will call `false` to return 1. `set_hostname` will return with the same return value. Then `30-hostname` will exit with the same exit value: ``` dhcpcd-10.0.6 starting dev: loaded udev DUID 00:03:00:01:3c:97:0e:e9:32:3c enp0s25: IAID 0e:e9:32:3c enp0s25: soliciting a DHCP lease enp0s25: offered 192.168.3.61 from 192.168.1.7 enp0s25: ignoring offer of 192.168.3.61 from 192.168.1.8 enp0s25: probing address 192.168.3.61/20 enp0s25: leased 192.168.3.61 for 3600 seconds enp0s25: adding route to 192.168.0.0/20 enp0s25: adding default route via 192.168.1.1 script_status: /usr/lib/dhcpcd/dhcpcd-run-hooks: WEXITSTATUS 1 exiting due to oneshot dhcpcd exited ``` Return with value 0 in case setting the hostname is not needed. Bug-Ubuntu: https://launchpad.net/bugs/2064926 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
|
Simple enough change. Probably worth merging on time for the next branch 10 release. |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the hostname is already set before dhcpcd is started,
need_hostnamewill hit the "No old hostname" case and will callfalseto return 1.set_hostnamewill return with the same return value. Then30-hostnamewill exit with the same exit value:Return with value 0 in case setting the hostname is not needed.
Bug-Ubuntu: https://launchpad.net/bugs/2064926