th/dhcp-options-sort #101
Closed
th/dhcp-options-sort #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the order is undefined and unstable. If you call GetManagedObjects() on D-Bus multiple times, it's a very nice property if the diff is small and not full not noise.
Otherwise, the output is unstable and changes every time.
lkundrak
force-pushed
the
th/dhcp-options-sort
branch
from
963edcd
to
5429673
Compare
bengal
reviewed
Apr 23, 2018
| nm_utils_strdict_to_variant (GHashTable *options) | ||
| { | ||
| GVariantBuilder builder; | ||
| gs_free gs_free const char **keys = NULL; |
clients/cli/common.c
Outdated
|
|
||
| options_arr = g_new (char *, nkeys + 1); | ||
| for (k = 0; k < nkeys; k++) | ||
| options_arr[i++] = g_strdup_printf ("%s = %s", keys[k], (const char *) g_hash_table_lookup (table, keys[k])); |
There was a problem hiding this comment.
Do we need both 'i' and 'k' variables?
|
fixed both and merged. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At several places, DHCP options are maintained in a hashtable.
Before serializing or printing them, sort them by name.