Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: misc. typos pt2 #205

Closed
wants to merge 1 commit into from
Closed

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Sep 15, 2018

Remainder of typos found using codespell -q 3 --skip="./shared,./src/systemd,*.po" -I ../NetworkManager-word-whitelist.txt whereby whitelist consists of:

ans
busses
cace
cna
conexant
crasher
iff
liftime
creat
nd
sav
technik
uint

Remainder of typos found using `codespell -q 3 --skip="./shared,./src/systemd,*.po" -I ../NetworkManager-word-whitelist.txt` whereby whitelist consists of:  
 ```
ans
busses
cace
cna
conexant
crasher
iff
liftime
creat
nd
sav
technik
uint
```
@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 15, 2018

Sorry for splitting up the commits in to 2. I wasn't sure about 3rd party files. Please let me know if any modifications are needed. Cheers

@vhumpa
Copy link
Collaborator

vhumpa commented Sep 17, 2018

NM CI: Please confirm test execution over this PR. Comment .ok\W+to\W+test. to confirm and/or .add\W+to\W+whitelist. to add the PR author in whitelist for future.

thom311 pushed a commit that referenced this pull request Sep 17, 2018
Remainder of typos found using `codespell -q 3 --skip="./shared,./src/systemd,*.po" -I ../NetworkManager-word-whitelist.txt` whereby whitelist consists of:
 ```
ans
busses
cace
cna
conexant
crasher
iff
liftime
creat
nd
sav
technik
uint
```

#205
@thom311
Copy link
Member

thom311 commented Sep 17, 2018

Merged to master.

Thanks!!

@thom311 thom311 closed this Sep 17, 2018
@thom311
Copy link
Member

thom311 commented May 15, 2020

hey @luzpaz. You contributed two patches to NetworkManager, and thereby some of the files were GPL2.0+ licensed. We are collecting agreement of the copyright holders on NetworkManager's GPL code, to relicense it under LGPL-2.1+. See ([1])

[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/blob/master/RELICENSE.md.

Would you give your agreement to that? If yes, could you please give a clear indication that you do agree, for example, simply be replying to this thread, and clearly expressing your thoughts? (or, if you have questions, we can discuss that too).

This is especially relevant due to https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/390#note_500824.

Your patches may be few, but I would prefer to just get your OK, instead of making such a judgement call myself.

Thank you.

@luzpaz
Copy link
Contributor Author

luzpaz commented May 16, 2020

@thom311 Sorry I missed this. I consent

lkundrak pushed a commit that referenced this pull request May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants